The headers are currently shown in a VariablesView instance. This is great, but if someone wants to batch-copy all the headers, they're goona' have a bad time. Something like "view source" would be nice (this can even just simply open a new tab with the headers listed as plain text).

See also bug 859138.

Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.

I'm offering to mentor the netmonitor actor changes needed to make available the raw request/response headers over the protocol. For UI we can either ask Victor for mentoring or we can do it in a separate bug. This also depends on the contributor's experience. To the potential contributor: please note this is not a good first bug - fixing this bug requires some experience with our codebase and work flow. Thanks!

Hi Victor! I've tried something with this feature. It adds a "Show raw headers" button in headers tab panel. This button shows 2 multi-lines textboxes with request and response headers, ready to consult or copy. What do you think ?

Comment on attachment 8489165 [details] [diff] [review] Add a plain request/response headers view. Review of attachment 8489165 [details] [diff] [review]: ----------------------------------------------------------------- I very much like this idea! Please fix the issues below and add a test, so we can land it ;) Thanks! ::: browser/devtools/netmonitor/netmonitor-view.js @@ +651,5 @@ > + > + let selectedRequestHeaders = selected.requestHeaders.headers; > + $("#raw-request-headers-textarea").value = writeHeaderText(selectedRequestHeaders); > + let selectedResponseHeaders = selected.responseHeaders.headers; > + $("#raw-resposne-headers-textarea").value = writeHeaderText(selectedResponseHeaders); Typo: raw-resposne. ::: browser/devtools/netmonitor/netmonitor.xul @@ +323,5 @@ > </hbox> > + <hbox id="raw-headers" > + class="tabpanel-summary-container" > + align="center" > + hidden="true" /> This is invalid xul. Don't close the hbox tag here. @@ +326,5 @@ > + align="center" > + hidden="true" /> > + <hbox id="raw-request-headers-textarea-box" flex="1" hidden="true"> > + <textbox id="raw-request-headers-textarea" flex="1" multiline="true"/> > + </vbox> </hbox> @@ +329,5 @@ > + <textbox id="raw-request-headers-textarea" flex="1" multiline="true"/> > + </vbox> > + <hbox id="raw-response-headers-textarea-box" flex="1" hidden="true"> > + <textbox id="raw-response-headers-textarea" flex="1" multiline="true"/> > + </vbox> Ditto!

- Issues fixed. - Toggle behaviour added for this 'Raw headers' button. - Tests added.

Comment on attachment 8496577 [details] [diff] [review] Add a plain request/response headers view. Review of attachment 8496577 [details] [diff] [review]: ----------------------------------------------------------------- I like this! There's a point that can be made about displaying the actual raw headers text instead of reconstructing it (as it is with the implementation in this patch), but we can always do that in a followup if anybody complains. The only suggestion I have is increasing the height of the texboxes a little more. A { height: ?vh } rule in the css should work, although I'll let you decide what number should be used, as long as it's in viewport units (vh). r+ with the above tweak.

Once you fix the above, please add a patch and a checkin-needed keyword in this bug.

Hi Victor. My patch is updated with the css rule requested. I'm not assigned to the bug, therefore I can't edit the bug to add checkin-needed keyword.

Can we please verify that this passes tests on Try first?

Test passes locally. I can't push it on Try. Victor, can you push my patch on Try ?

Sure.

Classic try: https://tbpl.mozilla.org/?tree=Try&rev=10c2dcf87563

My test failed on Try. I've updated my patch to address the issue.

If the try is green this time, don't forget to add the checkin-needed flag. Thanks!

Try is green.

Release Note Request (optional, but appreciated) [Why is this notable]: New feature in netmonitor [Suggested wording]: Network Monitor : New request/response headers view [Links (documentation, blog post, etc)]: http://hacks.mozilla.org/2014/12/pseudo-elements-promise-inspection-raw-headers-and-much-more-firefox-developer-edition-36/