Closed
Bug 859159
Opened 12 years ago
Closed 12 years ago
Keyboard layout broken for 'tel' and 'number' input
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mihai, Assigned: mihai)
References
Details
Attachments
(2 files)
Screenshots for 'number' and 'tel' input keyboards
The keyboard layout for 'tel' and 'number' inputs is broken for gaia/master (35238a3) by patch for Bug 853425 apparently (NOTE: v1-train not affected as the respective patch has not been uplifted yet).
STR (ENG)
---------
1. Go to "UI tests" app from the homescreen
2. Select "Keyboard test"
3. Tap on input field for "Input type=number" and "Input type=tel"
Expected: Keyboard appears on screen displaying the appropriate layout
Actual: The keyboard layout is broken (see attachment)
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mihai
|
|
Assignee | |
Comment 1•12 years ago
|
||
The patch for Bug 853425 introduces an error at line 507 in apps/keyboard/render.js by not setting the className, thus breaking the keyboard layout for 'tel' and 'number' inputs.
Attachment #734419 -
Flags: review?(dflanagan)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #734419 -
Attachment mime type: text/plain → text/html
|
||
Comment 2•12 years ago
|
||
Comment on attachment 734419 [details]
Pull Request #9031 - Fix keyboard layout
I reviewed that broken patch. Sorry I didn't think to test it against the UITests app. Thanks for finding and fixing this!
Attachment #734419 -
Flags: review?(dflanagan) → review+
|
|
||
Comment 3•12 years ago
|
||
Landed in gaia master: https://github.com/mozilla-b2g/gaia/commit/46f4ef4cf39f945cee7d0ce207270fb784cba02a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•