Closed Bug 859287 Opened 12 years ago Closed 12 years ago

After the toolbar customization dialog is used, the "Get Mail" pull down does not display full width until TB is restarted.

Categories

(Thunderbird :: Toolbars and Tabs, defect)

21 Branch
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 23.0

People

(Reporter: jsbruner, Assigned: aceman)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Screenshot of the bug. (deleted) —
On the current Daily (V. 23), when using the Icon Only mode, the get mail pull down menu does not display it's full width and dramatically cuts off the names of each account. The issue does *not* occur on Thunderbird V. 17.0.5. Attached is a screenshot of the issue.
Odd, after trying again, I can not reproduce it. Going to try to find the cause of this...
Ah, there we go. This issue still happens only on V. 23, but only occurs when the first click after you change the tab icon type. (E.G. Text to Text beside icons, etc).
Confirming on Win XP. After restart of TB with the Icons only mode, the popup is fine. It also happens just after switching from Icons only to "Icons beside text" mode. So it happens after any switch. I wonder if this isn't caused by bug 860093. Josiah, maybe you could try the trivial change proposed in bug 860093 and see if it helps.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Re-opening bug. Tried the patch and it does not fix the issue.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
I can reproduce on latest beta, aurora and daily. Looking onto the list of patches in bug 824150 which landed until mid-February, I don't think that this is a regression by that bug.
OS: Mac OS X → All
I get this error when closing the Customize palette: Error: TypeError: toolbox.getElementById is not a function Source file: chrome://messenger/content/mailCore.js But bug 860093 does not fix the problem here. I think this may be fallout from bug 813218. Who would have expected the Get Mail menupopup parasites on a folder picker :)
Assignee: nobody → acelists
Blocks: 813218
When switching the mode the button-getMsgPopup gets a width="100" on Win7 (not checked other platform but it would be the same) which makes the small popup. After reboot no width is set.
Yes, that's the new code added in bug 813218. When we get into the customize mode (have id.startsWith("wrapper")) I set width=100 and save the original width in another attribute. But for this popup the original width is never restored back after leaving the customize mode. I'm on it.
Status: REOPENED → ASSIGNED
Version: 23 → 21
Attached patch patch (deleted) — Splinter Review
This seems to do it. Josiah, can you confirm?
Attachment #735933 - Flags: review?(neil)
Attachment #735933 - Flags: feedback?(josiah)
(In reply to :aceman from comment #10) > Created attachment 735933 [details] [diff] [review] > patch > > This seems to do it. > Josiah, can you confirm? Yep, issue fixed. Thanks Ace.
Comment on attachment 735933 [details] [diff] [review] patch Sorry, I can't review this because I don't have a test case (Thunderbird doesn't count to me as a test case).
Attachment #735933 - Flags: review?(neil)
(In reply to Josiah Bruner [:JosiahOne] from comment #2) > Ah, there we go. This issue still happens only on V. 23, but only occurs > when the first click after you change the tab icon type. (E.G. Text to Text > beside icons, etc). If this is really a regression from bug 813218 then this should happen since TB21. And for me it is enough to just open the Customize dialog and clicking Done.
Summary: When using "Icon only" mode, the "Get Mail" pull down does not display full width. → After the toolbar customization dialog is used, the "Get Mail" pull down does not display full width until TB is restarted.
(In reply to neil@parkwaycc.co.uk from comment #12) > Sorry, I can't review this because I don't have a test case > (Thunderbird doesn't count to me as a test case). OK, I see Seamonkey's Get mail menulist is made via rdf, not the folder picker.
Attachment #735933 - Flags: feedback?(josiah) → review?(mkmelin+mozilla)
Comment on attachment 735933 [details] [diff] [review] patch Review of attachment 735933 [details] [diff] [review]: ----------------------------------------------------------------- Seems to fix it! r=mkmelin
Attachment #735933 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 12 years ago12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: