Closed Bug 859491 Opened 12 years ago Closed 12 years ago

-Wreorder build warning for XPCJSRuntime constructor

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New build warning (seen on my local m-i build): { js/xpconnect/src/xpcprivate.h: In constructor ‘XPCJSRuntime::XPCJSRuntime(nsXPConnect*)’: js/xpconnect/src/xpcprivate.h:968:10: warning: ‘XPCJSRuntime::mExceptionManagerNotAvailable’ will be initialized after [-Wreorder] js/xpconnect/src/xpcprivate.h:964:15: warning: ‘JSObject* XPCJSRuntime::mJunkScope’ [-Wreorder] js/xpconnect/src/XPCJSRuntime.cpp:2637:1: warning: when initialized here [-Wreorder] } hg blame says this was introduced by https://hg.mozilla.org/mozilla-central/rev/36fcd3edc6b8 (bug 820170)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Attached patch fix (deleted) — Splinter Review
Attachment #734812 - Flags: review?(bobbyholley+bmo)
The fix sticks mJunkScope after mLastActiveTime and before mExceptionManagerNotAvailable. Here's a snippet of the header file, as touched by the commit in comment 0, to show that the new ordering is correct: 3.28 PRTime mLastActiveTime; // -1 if active NOW [...] 3.31 + JSObject* mJunkScope; [...] 3.35 bool mExceptionManagerNotAvailable; https://hg.mozilla.org/mozilla-central/rev/36fcd3edc6b8#l3.28
Attachment #734812 - Flags: review?(bobbyholley+bmo) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: