Closed
Bug 859585
Opened 12 years ago
Closed 11 years ago
Intermittent B2G emulator Marionette test_outgoing_reject.js | ScriptTimeoutException: timed out and others
Categories
(Testing :: Marionette Client and Harness, defect)
Tracking
(firefox23 wontfix, firefox24 wontfix, firefox25 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)
RESOLVED
FIXED
mozilla25
People
(Reporter: RyanVM, Assigned: rwood)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
rwood
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=21561588&tree=Mozilla-Inbound
b2g_ics_armv7a_gecko_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-04-08 07:41:22 PDT for push 99cfae75ee7c
slave: tst-linux64-ec2-356
14:54:09 INFO - TEST-START test_outgoing_reject.js
14:54:20 INFO - /builds/slave/test/build/tests/marionette/tests/dom/telephony/test/marionette/test_outgoing_reject.js, runTest (marionette_test.MarionetteJSTestCase) ... ERROR
14:54:20 INFO - ======================================================================
14:54:20 INFO - ERROR: /builds/slave/test/build/tests/marionette/tests/dom/telephony/test/marionette/test_outgoing_reject.js, runTest (marionette_test.MarionetteJSTestCase)
14:54:20 INFO - ----------------------------------------------------------------------
14:54:20 INFO - Traceback (most recent call last):
14:54:20 INFO - File "/builds/slave/test/build/tests/marionette/marionette/marionette_test.py", line 212, in runTest
14:54:20 INFO - results = self.marionette.execute_js_script(js, args, special_powers=True)
14:54:20 INFO - File "/builds/slave/test/build/tests/marionette/marionette/marionette.py", line 560, in execute_js_script
14:54:20 INFO - scriptTimeout=script_timeout)
14:54:20 INFO - File "/builds/slave/test/build/tests/marionette/marionette/marionette.py", line 320, in _send_message
14:54:20 INFO - self._handle_error(response)
14:54:20 INFO - File "/builds/slave/test/build/tests/marionette/marionette/marionette.py", line 369, in _handle_error
14:54:20 ERROR - raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
14:54:20 ERROR - TEST-UNEXPECTED-FAIL | test_outgoing_reject.js | ScriptTimeoutException: timed out
14:54:20 INFO - ----------------------------------------------------------------------
14:54:20 INFO - Ran 1 test in 11.017s
14:54:20 WARNING - FAILED (errors=1)
etc...
Comment 1•12 years ago
|
||
This is another case where an emulator callback took a long time, causing the test to fail.
Blocks: b2g-testing
Updated•12 years ago
|
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 6•11 years ago
|
||
I'll have a look...
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 8•11 years ago
|
||
Fix intermittent failure by ensuring the previous emulator command has finished before issuing the next one (the emulator was falling behind). Also addresses the same type of failure in the telephony test in Bug 842322.
Attachment #773333 -
Flags: review?(jgriffin)
Comment 9•11 years ago
|
||
Comment on attachment 773333 [details] [diff] [review]
Fix intermittent failures
Review of attachment 773333 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
::: dom/telephony/test/marionette/test_outgoing_already_held.js
@@ +84,4 @@
> });
> };
> +
> + rcvdEmulatorCallback = false;
use 'let' here
@@ +208,4 @@
> });
> };
> +
> + rcvdEmulatorCallback = false;
use 'let' here
@@ +221,5 @@
> + is(result[0], "inbound from " + inNumber + " : held");
> + is(result[1], "outbound to " + outNumber + " : active");
> + is(result[2], "OK");
> + hangUpIncoming();
> + });
nit: extra whitespace at end of this line
::: dom/telephony/test/marionette/test_outgoing_reject.js
@@ +107,4 @@
> });
> };
> +
> + rcvdEmulatorCallback = false;
use 'let' here
Attachment #773333 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 10•11 years ago
|
||
Updated patch as per review comments (thanks JGriffin), carrying forward the r+.
Attachment #773333 -
Attachment is obsolete: true
Attachment #773923 -
Flags: review+
Assignee | ||
Comment 11•11 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=7b86d8391c91
Assignee | ||
Comment 12•11 years ago
|
||
Been awhile since I pushed to try, the syntax changed... pushed to try again:
https://tbpl.mozilla.org/?tree=Try&rev=8b73d4b8c9a7
Assignee | ||
Comment 13•11 years ago
|
||
Comment 14•11 years ago
|
||
Assignee: nobody → rwood
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Assignee | ||
Comment 15•11 years ago
|
||
Setting checkin-needed for b2g18 whenever you're doing your next bunch of uplifts Ryan, thanks!
Keywords: checkin-needed
Whiteboard: [checkin-needed]
Reporter | ||
Comment 16•11 years ago
|
||
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox23:
--- → wontfix
status-firefox24:
--- → wontfix
status-firefox25:
--- → fixed
Keywords: checkin-needed
Whiteboard: [checkin-needed]
Reporter | ||
Comment 17•11 years ago
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
Comment 18•2 years ago
|
||
Moving bug to Testing::Marionette Client and Harness component per bug 1815831.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•