Open
Bug 860067
Opened 12 years ago
Updated 2 years ago
Enable WebSMS on Android using a helper service installed on demand to request required permissions
Categories
(GeckoView :: General, defect, P5)
Tracking
(fennec+)
NEW
Tracking | Status | |
---|---|---|
fennec | + | --- |
People
(Reporter: blassey, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
mounir
:
feedback+
|
Details | Diff | Splinter Review |
We decided about a year ago that the permissions required to ship WebSMS were too scary. They turned off many users without offering any added benefit for them since no existing web apps used the API.
I'm hoping this set up can be a good compromise. When the API gets exercised for the first time, Firefox asks the user to install a helper service that will request the additional permissions.
This WIP patch does just enough to send an SMS. It has a menu item to trigger the APK installation (CC'ing Ian to figure out what UX we want around that) and comments out the PermissionManager calls for testing.
Attachment #735461 -
Flags: feedback?(mounir)
Comment 1•12 years ago
|
||
Comment on attachment 735461 [details] [diff] [review]
WIP patch
Review of attachment 735461 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not really sure what my feedback is for exactly. Generally speaking, it looks good. The hack is quite nice ;)
The only two comments I have are listed below.
::: mobile/android/base/GeckoSmsProtocol.java
@@ +2,5 @@
> +
> +public class GeckoSmsProtocol {
> + public static final int VERSION = 0;
> + public static final int ACTION_QUERY_VERSION = 1;
> + public static final int ACTION_SEND = 2;
I'm not sure I understand. Does that mean that Firefox Android will only ask the service to send stuff?
::: mobile/android/confvars.sh
@@ +51,4 @@
>
> MOZ_FENNEC=1
>
> +MOZ_WEBSMS_BACKEND=1
I think we could actually simply remove MOZ_WEBSMS_BACKEND in that case. It has been created only for Firefox Android.
Attachment #735461 -
Flags: feedback?(mounir) → feedback+
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Mounir Lamouri (:mounir) from comment #1)
> Comment on attachment 735461 [details] [diff] [review]
> WIP patch
>
> Review of attachment 735461 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I'm not really sure what my feedback is for exactly. Generally speaking, it
> looks good. The hack is quite nice ;)
>
> The only two comments I have are listed below.
>
> ::: mobile/android/base/GeckoSmsProtocol.java
> @@ +2,5 @@
> > +
> > +public class GeckoSmsProtocol {
> > + public static final int VERSION = 0;
> > + public static final int ACTION_QUERY_VERSION = 1;
> > + public static final int ACTION_SEND = 2;
>
> I'm not sure I understand. Does that mean that Firefox Android will only ask
> the service to send stuff?
No, I just have only plumbed up the IPC for send() so far. That list will grow as I flesh out the rest of it.
Reporter | ||
Updated•12 years ago
|
tracking-fennec: ? → +
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → blassey.bugs
Reporter | ||
Updated•6 years ago
|
Assignee: lassey → nobody
Comment 4•3 years ago
|
||
Moving all open Core::Widget: Android bugs to GeckoView::General (then the triage owner of GeckoView will decide which ones are valuable and which ones should be closed).
Component: Widget: Android → General
Product: Core → GeckoView
Version: Trunk → unspecified
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•