Let's get a start on reducing the dom/bindings noise.

Comment on attachment 735957 [details] [diff] [review] part 1. Root WebIDL dictionary ParseJSON. smaug Review of attachment 735957 [details] [diff] [review]: ----------------------------------------------------------------- Uhh this pattern returning *cx is quite funny! Maybe<Rooted<Value>> is only used when and defined and everything lives on the stack, so this should be okay. ::: dom/bindings/Codegen.py @@ +6818,5 @@ > (" bool Init(const nsAString& aJSON)\n" > " {\n" > " mozilla::Maybe<JSAutoRequest> ar;\n" > " mozilla::Maybe<JSAutoCompartment> ac;\n" > + " Maybe< JS::Rooted<JS::Value> > json;\n" Drop the mozilla:: for the others? Is that first space needed?

Comment on attachment 735961 [details] [diff] [review] part 3. Root ErrorResult::ThrowJSException. Review of attachment 735961 [details] [diff] [review]: ----------------------------------------------------------------- Easy enough as well!

> Drop the mozilla:: for the others? Done. > Is that first space needed? No, but I prefer the symmetry, and the last space _is_ needed.

Comment on attachment 735957 [details] [diff] [review] part 1. Root WebIDL dictionary ParseJSON. smaug Drop the space after <

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa9337d57ed https://hg.mozilla.org/integration/mozilla-inbound/rev/df6981fad6a2 https://hg.mozilla.org/integration/mozilla-inbound/rev/fc32e1f944e3

https://hg.mozilla.org/mozilla-central/rev/dfa9337d57ed https://hg.mozilla.org/mozilla-central/rev/df6981fad6a2 https://hg.mozilla.org/mozilla-central/rev/fc32e1f944e3