David Flanagan [:djf] Assignee
	Description • 12 years ago

The prediction engine does not always find and suggest english contractions. If I type "dont" it suggests "don't". But if I type "ill" "ive" or "cant" it does not suggest I'll, I've, and can't. These are really common and need to work for English auto-correction.

I'd suggest that the prediction engine may need to include a special case for insertion of apostrophes--the insertion of an apostrophe shouldn't reduce the weight of a match the way the insertion of some other character would.

We may also find that we need to layer a per-language hard-coded list of common corrections on top of the prediction engine. I'd store that list in the settings database, where it could be configured by vendors so that they can customize important auto-corrections needed in their markets.

	David Flanagan [:djf] Assignee
	Comment 1 • 12 years ago

Editing this bug so it isn't just about contractions in english.  French also uses apostrophes (and hyphens).  And lots of languages use accented letters.

Our search algorithm ought to allow insertions of apostrophes and hypens and the replacement of letters with accented versions without any penalty on the weight.  Those corrections come for free.  Other corrections, where we are guessing that the user did something wrong should reduce the weight of the prediction.

In order to do this efficiently, each dictionary will have to have some kind of header that identifies the insertions (like apostrophe and hyphen) and replacements (like a to á) used in the language.  Otherwise we'd have to try all possible diacritics for each letter.

	Mike Lee [:mlee]
	Comment 2 • 12 years ago

Adding whiteboard tags for tracking via srumbu.gs.

	David Flanagan [:djf] Assignee
	Comment 3 • 12 years ago

Preemptively asking for leo+ all the bugs blocking the keyboard auto-correct umbrella bug 797170.

	Joe Cheng [:jcheng] (please needinfo)
	Comment 4 • 12 years ago

seem like a product/UX decision whether we need auto-correct in 1.1

	Peter Dolanjski [:pdol]
	Comment 5 • 12 years ago

Chris is driving keyboard improvement decisions.

	David Flanagan [:djf] Assignee
	Comment 6 • 12 years ago

Fixed by parent bug 865484.

	Mike Lee [:mlee]
	Comment 7 • 12 years ago

Tracking since this change is wanted by UX but quality of fix needs to be assessed before decision to uplift. See below:

On 5/7/13 12:03 AM, Christopher Lee wrote:

    Thanks Francis. 

    Sounds like you and Josh are going to review the latest patches from David tomorrow and provide an assessment on the quality.  

    I'm also going to get a build tomorrow and evaluate the latest changes and we can collectively make a call on if it's ready for uplift.

	:CSchmoeckel
	Comment 8 • 11 years ago

Entering characters for a contraction without an apostrophe now correctly suggests the contraction spelled with the punctuation. Checked 10 different contractions including all of those in Comment 1. 
Tested on b2g/nigghtly/mozilla-central-unagi/latest.

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/3c6f2394995d
Gaia: d2ad0f1a5a6be8a2d6df721ba3c2b33e037c423b

	David Flanagan [:djf] Assignee
	Comment 9 • 11 years ago

Uplifted to v1-train in bug 873934