Closed Bug 860696 Opened 12 years ago Closed 11 years ago

B2G emulator: support Bluetooth tests (adapter getter/setter and device discovery)

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.0)

RESOLVED FIXED
feature-b2g 2.0

People

(Reporter: jhlin, Assigned: vicamo)

References

Details

Attachments

(1 file, 9 obsolete files)

Bluetooth tests will send HCI packets to emulator and expect it to reply accordingly. Also need new QEMU commands to support test fixture setup and state inspection.
Blocks: 860695
Depends on: 852583
Blocks: 860697, 860698
No longer blocks: 860695
Modify qemu to support 3 types of operation: 1) Get BT adapter properties * properties to get enable, name, BD address, discoverable, discovering * for the following tests - turn on/off Bluetooth - get adapter properties: BD address, name, discoverable - set mutable adapter properties: name, discoverable 2) Add fake remote devices * remote device properties to set name, BD address, class of service(CoD), service UUID * for the following test - discover remote devices 3) Implement connection handling * [TBD] * for the following test - pair/unpair
Attached patch patch v2 for remote device adding (obsolete) (deleted) — Splinter Review
Attach patch that - creates local HCI layer and remote L2CAP & SDP layers - adds fake remote devices - gets local properties Instruction: 1) patch the attachment under external/qemu 2) build emulator and run 3) run command "bt get <prop>" to get properties. <prop> includes "name", "addr", "discoverable", "discovering" 4) run command "bt radd <bdaddr>,<name>" to add fake remote devices. <bdaddr> is BD address of the form xx:xx:xx:xx:xx:xx. Note this attachment already includes my previous patch.
Attached patch patch v3 for authentication completion (obsolete) (deleted) — Splinter Review
Attach patch that - completes authentication - emulates local HCI layer & remote L2CAP & SDP layers - adds fake remote devices - gets local properties
Attachment #741194 - Attachment is obsolete: true
Attached file BT on/off test (obsolete) (deleted) —
Please run './test.sh marionette <file path>/test_bt_on_off.py' Sometimes test will fail becuase 'bt get name' returns empty string.
(In reply to John Lin[:jolin][:jhlin] from comment #5) > Created attachment 744502 [details] > BT on/off test > > Please run './test.sh marionette <file path>/test_bt_on_off.py' > Sometimes test will fail becuase 'bt get name' returns empty string. This problem no longer happens in latest test case implementation.
Attached file marionette tests (obsolete) (deleted) —
Sometimes testing pair will make QEMU frozen.(Frequency 1/2 ~ 1/3) Please run attached scripts with: ./test.sh marionette --address=localhost:2828 --emulator=arm --type=qemu <marionette/test_bt_pair.py>
Attached patch Patch v4 to fix frozen qemu during pairing (obsolete) (deleted) — Splinter Review
bt_qemu_v4 - reject remote devices with duplicate BD address - authentication - local HCI layer + remote L2CAP & SDP - add fake remote devices - get local properties
Attachment #743499 - Attachment is obsolete: true
Vicamo, please help review the following pull request. Note this pull request includes also your changes under external/qemu.
Attachment #752627 - Flags: review?(vyang)
Attached patch bt_qemu v5 (obsolete) (deleted) — Splinter Review
Attach my latest patch.
Attachment #748686 - Attachment is obsolete: true
Attachment #752627 - Attachment is patch: false
Attachment #752627 - Attachment mime type: text/plain → text/html
Attachment #752627 - Flags: review?(vyang)
Blocks: b2g-emulator
Assignee: btian → echou
Attached file gaia-pr.html (obsolete) (deleted) —
Hi vicamo, Please review my patch on GitHub. Jamin's test cases (bug 860697, bug 860698) are based on my emulator implementation. Thank you.
Attachment #752627 - Attachment is obsolete: true
Attachment #8365821 - Flags: review?(vyang)
Summary: B2G emulator: support Bluetooth tests → B2G emulator: support Bluetooth tests (adapter getter/setter and device discovery)
Blocks: 860695
Blocks: 968624
Attached file pull request 55 (obsolete) (deleted) —
* v2 patch. All comments for v1 have been taken.
Attachment #8365821 - Attachment is obsolete: true
Attachment #8365821 - Flags: review?(vyang)
Attachment #8372038 - Flags: review?(vyang)
My working branch: https://github.com/vicamo/b2g_platform_external_qemu/tree/bugzilla/860696/bt-test-commands Supported commands so far: * mux bt [<bd_addr>] * bt list [<bd_addr>] * bt property [<bd_addr> [<name> [<value>]]]
Assignee: echou → vyang
Attached file Github pull request for external/qemu (deleted) —
Attachment #752629 - Attachment is obsolete: true
Attachment #8372038 - Attachment is obsolete: true
Attachment #8372038 - Flags: review?(vyang)
Attachment #8377365 - Flags: review?(echou)
Comment on attachment 8377365 [details] Github pull request for external/qemu r=me with nits picked and problem answered. Please check my comments on GitHub page. Thank you.
Attachment #8377365 - Flags: review?(echou) → review+
Comments addresses, waiting for merge window.
Hi vicamo, I think we're ready to go. :)
Comment on attachment 744502 [details] BT on/off test Not used anymore.
Attachment #744502 - Attachment is obsolete: true
Comment on attachment 747264 [details] marionette tests Not used anymore.
Attachment #747264 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
feature-b2g: --- → 2.0
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: