Closed
Bug 861095
Opened 12 years ago
Closed 12 years ago
B2G MMS: b2g crash on opening a MMS message
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox21 | --- | unaffected |
| firefox22 | --- | unaffected |
| firefox23 | --- | fixed |
| b2g18 | --- | fixed |
| b2g18-v1.0.0 | --- | unaffected |
| b2g18-v1.0.1 | --- | unaffected |
People
(Reporter: vicamo, Assigned: vicamo)
References
()
Details
(Keywords: crash, Whiteboard: [b2g-crash])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
One piece omitted in bug 847744, no MMS handling in MobileMessageCursorParent::NotifyCursorResult()[1]. Then b2g falls in the assertion when getMessages() returns a MMS message and then restarts itself.
[1]: https://github.com/mozilla/releases-mozilla-central/blob/master/dom/mobilemessage/src/ipc/SmsParent.cpp#L715
|
Assignee | |
Comment 1•12 years ago
|
||
Nominate for leo+ because b2g restarts every time an user clicks a message thread with MMS messages.
blocking-b2g: --- → leo?
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #736710 -
Flags: review?(mounir)
|
|
Assignee | |
Updated•12 years ago
|
Summary: B2G MMS: b2g crash on → B2G MMS: b2g crash on opening a MMS message
|
||
Comment 3•12 years ago
|
||
Adding [NO_UPLIFT]. Just making sure all the MMS bugs have this tag for now.
This must be landed after bug 847744 lands.
Whiteboard: [NO_UPLIFT]
|
||
Comment 5•12 years ago
|
||
Comment on attachment 736710 [details] [diff] [review]
patch
Review of attachment 736710 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/mobilemessage/src/ipc/SmsParent.cpp
@@ +707,5 @@
>
> + nsCOMPtr<nsIDOMMozMmsMessage> iMms = do_QueryInterface(aResult);
> + if (iMms) {
> + MmsMessage* message = static_cast<MmsMessage*>(aResult);
> + ContentParent *parent = static_cast<ContentParent*>(Manager()->Manager());
coding style: "ContentParent* parent"
Attachment #736710 -
Flags: review?(mounir) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Address review comment, add r=mounir.
Attachment #736710 -
Attachment is obsolete: true
Attachment #736834 -
Flags: review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
||
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
Assignee | |
Comment 9•12 years ago
|
||
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → unaffected
status-b2g18-v1.0.1:
--- → unaffected
status-firefox21:
--- → unaffected
status-firefox22:
--- → unaffected
status-firefox23:
--- → fixed
Whiteboard: [b2g-crash][NO_UPLIFT] → [b2g-crash]
|
||
Updated•11 years ago
|
Flags: in-moztrap?
QA Contact: amiller
You need to log in
before you can comment on or make changes to this bug.
Description
•