http://i.imgur.com/AppHumC.png I've been flagging them as I'm seeing them: https://marketplace.firefox.com/reviewers/themes/queue/flagged Not sure what happens if they're approved, I'm erring on the side of caution...

P1 to investigate

http://sentry.dmz.phx1.mozilla.com/addons/addons/group/13055/ OSError: [Errno 17] File exists Stacktrace (most recent call last): File "celery/execute/trace.py", line 153, in trace_task R = retval = task(*args, **kwargs) File "nuggets/celeryutils.py", line 35, in wrapped return fun(*args, **kw) File "amo/decorators.py", line 175, in wrapper result = f(*args, **kw) File "addons/tasks.py", line 229, in save_persona_image with storage.open(full_dst, 'wb') as fp: File "django/core/files/storage.py", line 33, in open return self._open(name, mode) File "amo/utils.py", line 912, in _open os.makedirs(parent) File "python2.6/os.py", line 157, in makedirs mkdir(name, mode)

I just approved one that was blank, but it shows up ok on the site: https://addons.mozilla.org/en-US/firefox/addon/bird-favourite/

Here's one I approved where the header image was blank in the review queue, and also appears to be blank on the edit page. The image shows up on the detail page, but when I hover over it the preview is black. https://addons.mozilla.org/en-US/firefox/addon/billard-billiard-balls/ http://i.imgur.com/ULyGtdt.png

Same with this: https://addons.mozilla.org/en-US/firefox/addon/sweet_lady_bug/

Can we give this bug a bump in priority?

I'm surprised it's a P1, actually. Kevin - any ideas on this?

https://marketplace.firefox.com/reviewers/themes/queue/single/dolphin-games http://f.cl.ly/items/212Y2U1V0C3f1D1j3t2d/Screen%20Shot%202013-04-25%20at%202.38.02%20PM.png https://marketplace.cdn.mozilla.net/_files/434136/header.png?1366903226 - 404 https://marketplace.cdn.mozilla.net/_files/434136/footer.png?1366903226 - 200

Was the fix from https://bugzilla.mozilla.org/show_bug.cgi?id=861234#c8 been pushed to production when that theme was submitted? Themes submitted before the patch may have blank images, but themes submitted after the patch makes it to production should be okay.

What should we do with the current themes? do they need to be resubmitted?

Probably, if the issue I found was the actual issue. I need to wait until after the patch is pushed and check if Sentry is still catching errors.

Ah, the patch is out as of 30 min ago or so

Marking resolved for now then. All themes submitted after the patch should be fine. After I can confirm it is all fixed, we can probably send emails out to people who have to resubmit.

Can I have a list of emails of people who have to resubmit? Thx

Kevin, how positive on a scale of "no idea" to "100% OMG I'm totally positive" are you that this patch fixes the images?

75% pretty sure, but good chance I'm wrong since it'd be difficult to reproduce race condition (if it was a race find). I'll check sentry in a bit

No tracebacks in Sentry since the patch, assume fix'd.

(In reply to Amy Tsay [:amyt] from comment #15) > Can I have a list of emails of people who have to resubmit? Thx I know we talked on IRC this morning, and we've got a plan for adding a Senior Reviewers group but now that I'm reviewing bugmail I'm not sure where we landed on this. If you need us to get a list of broken themes let me know and I'll file another bug for it.

Yes, if it's possible to find out which themes are broken, I'll reach out to those authors.

I think we can piggyback on bug 641644 to get the info