Closed Bug 861269 Opened 12 years ago Closed 12 years ago

GC: Continuing the rooting of XPConnect

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(3 files, 2 obsolete files)

1 - Change arguments from foo_ to fooArg style
(deleted), patch
bholley
: review+
Details | Diff | Splinter Review
4 - Rooting in nsXPConnect.cpp
(deleted), patch
bholley
: review+
Details | Diff | Splinter Review
5 - Rooting in XPCJSID.cpp
(deleted), patch
bholley
: review+
Details | Diff | Splinter Review
No description provided.
Attachment #736874 - Flags: review?(bobbyholley+bmo)
Attached patch 2 - Make AutoPropertyDescriptorRooter public (obsolete) (deleted) — — Splinter Review
This is needed for rooting XrayWrapper.cpp
Attachment #736875 - Flags: review?(terrence)
Attached patch 3 - Rooting in XrayWrapper.cpp (obsolete) (deleted) — — Splinter Review
Attachment #736876 - Flags: review?(bobbyholley+bmo)
Attached patch 4 - Rooting in nsXPConnect.cpp (deleted) — — Splinter Review
Attachment #736877 - Flags: review?(bobbyholley+bmo)
Attached patch 5 - Rooting in XPCJSID.cpp (deleted) — — Splinter Review
Attachment #736878 - Flags: review?(bobbyholley+bmo)
Comment on attachment 736875 [details] [diff] [review] 2 - Make AutoPropertyDescriptorRooter public Review of attachment 736875 [details] [diff] [review]: ----------------------------------------------------------------- I'd prefer to get bug 860572 polished up and landed to handle this case. I'll work on that more today.
Attachment #736875 - Flags: review?(terrence)
Attachment #736874 - Flags: review?(bobbyholley+bmo) → review+
Attachment #736876 - Flags: review?(bobbyholley+bmo) → review+
Attachment #736877 - Flags: review?(bobbyholley+bmo) → review+
Attachment #736878 - Flags: review?(bobbyholley+bmo) → review+
Attachment #736875 - Attachment is obsolete: true
Attachment #736876 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: