Closed Bug 861338 Opened 12 years ago Closed 11 years ago

[browserconsole] Cache Console.jsm API calls with ConsoleAPIStorage.jsm

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 24

People

(Reporter: msucan, Assigned: msucan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

proposed patch
(deleted), patch
jwalker
: review+
Details | Diff | Splinter Review
We should cache Console.jsm API calls with ConsoleAPIStorage.jsm such that the messages show in the Browser Console even if it was not open at the time of the API call.
Blocks: remove-cu-reportError
Attached patch proposed patch (deleted) — — Splinter Review
This is the proposed patch. I changed _consoleStorage from an object to a map in the hope that's more optimized for our actual use-case. Since we can't tell if messages are being logged during private browsing, should we clear the "jsm" storage whenever pb-last-context-exited?
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #759811 - Flags: review?(jwalker)
Attachment #759811 - Flags: review?(jwalker) → review+
Landed: https://hg.mozilla.org/integration/fx-team/rev/f4ec1953f7e5
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f4ec1953f7e5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: