Closed Bug 861395 Opened 12 years ago Closed 12 years ago

Log the original exception stack trace and add some paranoid exception checks

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox22 wontfix, firefox23 fixed)

RESOLVED FIXED
Firefox 23
Tracking Status
firefox22 --- wontfix
firefox23 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Part 1: Log the `cause` exception that we report to Socorro
Attachment #736983 - Flags: review?(bugmail.mozilla)
Part 2: Still try to report exception if the exception reporter throws an exception.
Attachment #736984 - Flags: review?(bugmail.mozilla)
Comment on attachment 736983 [details] [diff] [review] part-1-log-original-exception.patch Review of attachment 736983 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #736983 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 736984 [details] [diff] [review] part-2-ignore-exception-reporter-exceptions.patch Review of attachment 736984 [details] [diff] [review]: ----------------------------------------------------------------- What case does this catch that wasn't caught before? If an exception is thrown anywhere stackTrace will end up null and so nothing will be reported, so I don't see how this helps.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4) > What case does this catch that wasn't caught before? If an exception is > thrown anywhere stackTrace will end up null and so nothing will be reported, > so I don't see how this helps. oops! <:) An earlier version of this patch only had the try {} around the SharedPreferences code because I wondered whether writing SharedPreferences after we just received an OutOfMemoryError could fail with another OutOfMemoryError. It was a purely hypothetical concern.
Attachment #736984 - Attachment is obsolete: true
Attachment #736984 - Flags: review?(bugmail.mozilla)
Attachment #737030 - Flags: review?(bugmail.mozilla)
Whiteboard: [keep open]
Target Milestone: --- → Firefox 23
Comment on attachment 737030 [details] [diff] [review] part-2-ignore-exception-reporter-exceptions-v2.patch r=me with the compile error fixed.
Attachment #737030 - Flags: review?(bugmail.mozilla) → review+
Whiteboard: [keep open]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: