STR: 0. In latest nightly, open a page with HTML5 video 1. Open the context menu for the video 2. Click "Show statistics" Expected results: See statistics Actual results: nothing happens Debugging shows that the custom event we use can't be inspected by the XBL code here: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/videocontrols.xml?rev=24c95448c549&mark=467#466 accessing any property of |e| results in a security exception. Bobby, can you elucidate what's going on here and how to work around it? I was going to try and fix bug 845555, but ran into this one instead...

This is also broken on aurora.

Actually, this seems to work in my limited testing. Essentially, I'm avoiding the use of the event object entirely and just toggling the statistics based on the expando property. The only reason there's still a parameter to the toggle function is the initialize code which forces it to 'true'. The comment indicates this is about fullscreen, so I tested with switching back and forth, and that seems to work. However, I'm not sure I understand the full reason behind that part of the code. Jared, can you confirm switching to fullscreen and back for a video (on OSX) with the button on the video would have triggered that part of the code?

(In reply to :Gijs Kruitbosch from comment #2) > Created attachment 737825 [details] [diff] [review] > Patch > > Actually, this seems to work in my limited testing. > > Essentially, I'm avoiding the use of the event object entirely and just > toggling the statistics based on the expando property. The only reason > there's still a parameter to the toggle function is the initialize code > which forces it to 'true'. The comment indicates this is about fullscreen, > so I tested with switching back and forth, and that seems to work. However, > I'm not sure I understand the full reason behind that part of the code. > Jared, can you confirm switching to fullscreen and back for a video (on OSX) > with the button on the video would have triggered that part of the code? Fullscreen worked very differently many versions ago (it opened a new window and cloned the media element in to that window). The new DOM Fullscreen API approach just takes the element and expands it to fit the size of the window (hiding other elements), so the fullscreen workaround may not be necessary anymore.

Comment on attachment 737825 [details] [diff] [review] Patch So, this patch fixes beta and aurora, too, so I'll just deal with it all in bug 845555. I'd probably want to leave the fullscreen stuff for a separate bug in order to reduce risk on beta.

So, why does this expando need to live in content? Does content set it somewhere? It seems like it should just live on the Xray wrapper (accessible to the XBL code but not to content)...