Closed
Bug 862360
Opened 12 years ago
Closed 12 years ago
Use the exported Promise.all instead of reimplementing it
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: past, Assigned: past)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
From bug 772119 comment 64. Green try push: https://tbpl.mozilla.org/?tree=Try&rev=bf22677d74a1
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #738000 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #738000 -
Flags: review? → review?(rcampbell)
Comment 2•12 years ago
|
||
Comment on attachment 738000 [details] [diff] [review] Patch v1 Review of attachment 738000 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/debugger/server/dbg-script-actors.js @@ +684,1 @@ > for (s of this.dbg.findScripts())]); Nitiest of nits: This line should be re-indented so that the "for" vertically aligns with "this" on the line above.
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Nick Fitzgerald [:fitzgen] from comment #2) > Nitiest of nits: This line should be re-indented so that the "for" > vertically aligns with "this" on the line above. I was just about to make it a single line, but OK :-)
Attachment #738000 -
Attachment is obsolete: true
Attachment #738000 -
Flags: review?(rcampbell)
Attachment #738034 -
Flags: review?(rcampbell)
Comment 4•12 years ago
|
||
(In reply to Panos Astithas [:past] from comment #3) > Created attachment 738034 [details] [diff] [review] > Patch v2 > > (In reply to Nick Fitzgerald [:fitzgen] from comment #2) > > Nitiest of nits: This line should be re-indented so that the "for" > > vertically aligns with "this" on the line above. > > I was just about to make it a single line, but OK :-) Ah yes, that works too :)
Comment 5•12 years ago
|
||
Comment on attachment 738034 [details] [diff] [review] Patch v2 Review of attachment 738034 [details] [diff] [review]: ----------------------------------------------------------------- no comment!
Attachment #738034 -
Flags: review?(rcampbell) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/335029350f8e
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/335029350f8e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•