Closed Bug 862360 Opened 12 years ago Closed 12 years ago

Use the exported Promise.all instead of reimplementing it

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: past, Assigned: past)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) (deleted) — Splinter Review
Attachment #738000 - Flags: review?
Attachment #738000 - Flags: review? → review?(rcampbell)
Comment on attachment 738000 [details] [diff] [review]
Patch v1

Review of attachment 738000 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/debugger/server/dbg-script-actors.js
@@ +684,1 @@
>                         for (s of this.dbg.findScripts())]);

Nitiest of nits: This line should be re-indented so that the "for" vertically aligns with "this" on the line above.
Attached patch Patch v2 (deleted) — Splinter Review
(In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> Nitiest of nits: This line should be re-indented so that the "for"
> vertically aligns with "this" on the line above.

I was just about to make it a single line, but OK :-)
Attachment #738000 - Attachment is obsolete: true
Attachment #738000 - Flags: review?(rcampbell)
Attachment #738034 - Flags: review?(rcampbell)
(In reply to Panos Astithas [:past] from comment #3)
> Created attachment 738034 [details] [diff] [review]
> Patch v2
> 
> (In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> > Nitiest of nits: This line should be re-indented so that the "for"
> > vertically aligns with "this" on the line above.
> 
> I was just about to make it a single line, but OK :-)

Ah yes, that works too :)
Comment on attachment 738034 [details] [diff] [review]
Patch v2

Review of attachment 738034 [details] [diff] [review]:
-----------------------------------------------------------------

no comment!
Attachment #738034 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/335029350f8e
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/335029350f8e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: