I am getting the following warnings in my web server (Apache) log file when running bugzilla locally: Use of uninitialized value at globals.pl line 795 (#1) Use of uninitialized value at globals.pl line 796 (#1) Use of uninitialized value at globals.pl line 797 (#1) Use of uninitialized value at globals.pl line 799 (#1) Use of uninitialized value at globals.pl line 800 (#1) This appears to be due to NULLs being returned by the SQL query a few lines back.

Also occurs on earlier lines 791 and 792 (and causes similar problems within the value_quote() calls on the next lines. Further investigation reveals that the reason I am seeing this error is that I have the text ... see bug <number> ... in my bug description, where <number> is not a bugnumber existing in the bugzilla database (I was referring back to bug numbers in a previous database I had migrated from into bugzilla). GetBugLink should check for this case, and not produce a link if it occurs.

One of things I intend to do sometime soon is start looking at my webserver logs and trying to solve some various warnings (There currently aren't any compile time warings, but there are a few run-time). Also, there's a bug somewhere about not turing bug ### into a link if it's doesn't exist which would also solve this particular problem.

Other bugs relating to bug numbers in links: bug 31168, bug 85709. I now have a patch that fixes this bug in my local installation - I'll attach it as soon as I've worked out how to create it against current (2.13) sources and how to attach it!!

See also bug 86923 for more similar error messages.

Sorry. Patch is (obviously) against 2.12 not 1.12!

Comment on attachment 39479 [details] [diff] [review] Patch (against 1.12) to fix this problem Needs work. Would be cleaner if the code, including the my declaration, was inside if (MoreSQLData()).

The patch I just uploaded uses if (MoreSQLData()), is against current CVS (to incorporate recent changes in that routine) and also impliments a cache so if the same bug number is mentioned twice in one report (which is fairly common) it only has to run the SQL query once.

This looks good, but I think the cache should be on bug number and link text, since it relies on the latter.

Given the fact the number is numeric, there should be no problems in you key on "$bugnum-$linktext".

Actually, that would fail to cache the SQL results between the same bug but with different link text (eg bug XXXXX and bug #XXXXX). Since we're really interested in caching the SQL results (I assume), maybe we should just cache a reference to the record list.

That's a very good point. This latest patch caches the values that can be used to build the link, not the link itslef.

Looks good, except: if ($bug_state eq $::unconfirmedstate) { ... if (! IsOpenedState($bug_state)) { This should probably be else. It doesn't matter but I think it makes it more obvious. Also, please quote the resolution and status. ATM people can hack their installations, soon they will have custom resolutions and hopefully statuses for 2.18.

I had a dream last night about using elsif there... :) Anyway, I've now run $title through value_quote() right before dumping it out to the %::buglink hash instead of doing each part individually (not that it matters much, it just meant I didn't have to type value_quote() as much :)

Comment on attachment 55548 [details] [diff] [review] value_quote() the entire $title I'm a big fan of your work.

This also fixes bug #85709, I believe. I'm thinking we should change the presentational HTML to CSS classes on the status, or perhaps templatise the HTML that gets output, but that is not necessary for this bug.

Comment on attachment 55548 [details] [diff] [review] value_quote() the entire $title If Matty tested the patch, r=gerv. If he didn't, someone will have to, so !r=gerv :-) Gerv

mpt: I saw in #mozwebtools this evening where you mentioned that you didn't want Bugzilla to link to non-existant bugs... that's covered in the patch to this bug.

I tested it, but I think both reviewers are supposed to test.

Oh, check it in :-) Gerv

Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.126; previous revision: 1.125 done

must... click... radio... button...

*** Bug 85709 has been marked as a duplicate of this bug. ***

*** Bug 136723 has been marked as a duplicate of this bug. ***

*** Bug 119890 has been marked as a duplicate of this bug. ***

*** Bug 144173 has been marked as a duplicate of this bug. ***