Closed
Bug 863008
Opened 12 years ago
Closed 12 years ago
Showing statistics is broken because of webidl conversion of custom event
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(seamonkey2.18 fixed, seamonkey2.19 fixed, seamonkey2.20 fixed)
RESOLVED
FIXED
seamonkey2.20
People
(Reporter: neil, Assigned: neil)
References
()
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
philip.chee
:
review+
iannbugzilla
:
approval-comm-aurora+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Now that events are webidl objects instead of XPConnect objects, they follow webidl security rules, which means that events created using chrome objects cannot be read from content. This affects the context menu which tries to send a chrome event to the videocontrols binding. The solution is to use a content object to create the event.
Assignee | ||
Updated•12 years ago
|
status-seamonkey2.18:
--- → affected
status-seamonkey2.19:
--- → affected
status-seamonkey2.20:
--- → affected
Assignee | ||
Comment 1•12 years ago
|
||
This patch has an extra line that works around an xbl_scopes issue that was also fixed in toolkit as part of bug 845555, but may or may not get uplifted.
Assignee | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
> in toolkit as part of bug 845555, but may or may not get uplifted.
Bug 845555 landed on aurora.
> var statsShowing = this.onVideo &&
> this.target.wrappedJSObject.mozMediaStatisticsShowing;
Don't you need to unwrap this as well?
Depends on: 845555
Flags: needinfo?(neil)
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Philip Chee from comment #3)
> > in toolkit as part of bug 845555, but may or may not get uplifted.
> Bug 845555 landed on aurora.
>
> > var statsShowing = this.onVideo &&
> > this.target.wrappedJSObject.mozMediaStatisticsShowing;
> Don't you need to unwrap this as well?
.wrappedJSObject is the old way to unwrap, I guess I could update it for consistency, but then I'm not sure how to wrap the line (pun intended).
Flags: needinfo?(neil)
Comment 5•12 years ago
|
||
Comment on attachment 738698 [details] [diff] [review]
Proposed patch
r=me
Attachment #738698 -
Flags: review?(philip.chee) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 738698 [details] [diff] [review]
Proposed patch
[Approval Request Comment]
Regression caused by (bug #): Some m-c change as usual
User impact if declined: Menuitem no longer works
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low, only affects the menuitem itself, and dependent m-c fixes have already landed
String changes made by this patch: None
Attachment #738698 -
Flags: approval-comm-beta?
Attachment #738698 -
Flags: approval-comm-aurora?
Attachment #738698 -
Flags: approval-comm-beta?
Attachment #738698 -
Flags: approval-comm-beta+
Attachment #738698 -
Flags: approval-comm-aurora?
Attachment #738698 -
Flags: approval-comm-aurora+
Updated•12 years ago
|
Target Milestone: --- → seamonkey2.20
Assignee | ||
Comment 8•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•