Closed
Bug 863390
Opened 11 years ago
Closed 11 years ago
Add test for _content == content
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
I could be wrong, but I don't see any tests for this.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #739294 -
Flags: review?(jst)
Assignee | ||
Updated•11 years ago
|
Attachment #739294 -
Flags: review?(jst) → review?(Ms2ger)
Comment 2•11 years ago
|
||
Comment on attachment 739294 [details] [diff] [review] does window.content === window._content? Review of attachment 739294 [details] [diff] [review]: ----------------------------------------------------------------- You are correct; we never hit the _content code in our test suite. Don't forget to fix the r=jst in the commit message.
Attachment #739294 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 3•11 years ago
|
||
bholley is making content and _content chrome-only, so I guess I should change the test so that it won't break with that.
Depends on: 864845
Assignee | ||
Comment 4•11 years ago
|
||
I got impatient so I landed this. try run: https://tbpl.mozilla.org/?tree=Try&rev=ef9284fca0eb https://hg.mozilla.org/integration/mozilla-inbound/rev/de480c18491a
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/de480c18491a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•