Closed
Bug 863709
Opened 12 years ago
Closed 11 years ago
Add a +remote option to "mach run" and "mach debug" to disable -no-remote
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #863092 +++
This is useful if you are working command-line handler code (as I was recently) or if you just want a command-line way to open a new link in your existing process.
Attachment #739579 -
Flags: review?(gps)
Comment 1•12 years ago
|
||
Comment on attachment 739579 [details] [diff] [review]
patch
Review of attachment 739579 [details] [diff] [review]:
-----------------------------------------------------------------
Kinda wish we didn't have to use +remote here. But, that train has left the station.
Attachment #739579 -
Flags: review?(gps) → review+
Comment 2•12 years ago
|
||
Can you please change this option to say "Do not pass any arguments by default"? That is a more scalable solution than coming up with one of these hacks every time. :-)
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #2)
> Can you please change this option to say "Do not pass any arguments by
> default"? That is a more scalable solution than coming up with one of these
> hacks every time. :-)
I thought of that, but I'm kind of hoping we can avoid adding more default arguments, and instead work on ensuring sensible behavior for all command-line users (including non-mach users) without passing arguments every time.
Semi-related: An alternate way to solve this bug would be adding a "-remote" options to nsAppRunner which could override an earlier "-no-remote". Then "mach run -remote" would do the right thing without any changes to mach itself. I'll explore that approach before landing this patch.
Comment 4•12 years ago
|
||
I thought that we already have a -remote option?
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> I thought that we already have a -remote option?
Oops, we do, and it's Linux-only and means something slightly different (it's to specify an X11 desktop, or something). I'm not sure if it would be possible to overload it in a compatible way or if we'd need some different name. If we do need a different name, I can't think of any non-horrible ones. :/
Comment 6•12 years ago
|
||
(In reply to comment #5)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> > I thought that we already have a -remote option?
>
> Oops, we do, and it's Linux-only and means something slightly different (it's
> to specify an X11 desktop, or something). I'm not sure if it would be possible
> to overload it in a compatible way or if we'd need some different name. If we
> do need a different name, I can't think of any non-horrible ones. :/
Yeah, sorry, what I meant was, "remote" is already taken. And it obviously doesn't do what you would expect it to, it's a Gecko command line option after all. :P
Assignee | ||
Comment 7•11 years ago
|
||
So, the alternatives to this all had issues of their own that I wasn't able to find great solutions for (e.g. comment 3, comment 4) so I'm going with my original patch for now because it's the simplest fix for my own use cases:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b37e8c3c0bf
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•