Closed Bug 863999 Opened 12 years ago Closed 11 years ago

Header in week view displays two months without a separator

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Type:
defect

Tracking

(blocking-b2g:-, b2g18 affected, b2g18-v1.0.1 affected)

Status:
RESOLVED FIXED
Milestone:
1.2 FC (16sep)
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
b2g18 --- affected
b2g18-v1.0.1 --- affected

People

(Reporter: striptm, Assigned: evanxd)

References

Details

(Keywords: l12y, unagi, Whiteboard: Unagi, Keon)

Attachments

(2 files)

Screenshot
(deleted), image/png
Details
Pull Request
(deleted), text/html
jlal
: review+
Details
Steps to reproduce: 1. Open the calendar app 2. Switch to the week view 3. Navigate to a week with days in two months (like Sunday April 28 to Wednesday May 1 Expected result: Header shows "April-May 2013" (or another separator) Actual result: Header shows "AprilMay 2013"
Confirmed here. Firefox 1.0.1 Geeksphone Keon
status-b2g18-v1.0.1: --- → affected
Keywords: unagi
Whiteboard: Unagi, Keon
Confirmed on Inari on Mozilla RIL v1.0.1, also reproduces in pt-BR and Spanish: Gaia 052253176f3ad495a1086e47a28fffbf07613388 BuildID 20130425070201 Version 18.0
Attached image Screenshot (deleted) —
Header shows "julioagosto 2013" in Spanish. Please see the Screenshot This defect still appears on Leo Build ID: 20130710070204 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/5b34e0cda635 Gaia: 61453c4d32beb15a33ec91b2e740e96e5ce45759 Platform Version: 18.1
Blocks: 892075
blocking-b2g: --- → leo?
Priority: -- → P2
Target Milestone: --- → 1.1 QE5
This is already existing in 1.0.1 and we are too late in 1.1 cycle to resolve this hence nominating for koi?
blocking-b2g: leo? → koi?
Adding localizers to see if they can find a work around for this.
Mila, what we need a space between words.
This does not depend on localizers, but on code to handle that when showing two months, there should be an space between the two.
blocking-b2g: koi? → koi+
Target Milestone: 1.1 QE5 → ---
Assignee: nobody → evanxd
Hi all, It's my WIP patch. https://github.com/evanxd/gaia/commit/041c394ce0f6d78a2c508fb8c5c645229fbb4560 The patch already added a space between the two months. And I'm working on the integration test for it.
Triage: This bug has been added to the v1.2 backlog but is not blocking release
blocking-b2g: koi+ → -
Attached file Pull Request (deleted) —
Hi James, Please help me review the patch. Thanks. :)
Attachment #795944 - Flags: review?(jlal)
Comment on attachment 795944 [details] Pull Request I have on tiny complaint (see github) otherwise this is amazing.... Nice work!
Attachment #795944 - Flags: review?(jlal) → review+
Hi James, I already updated the patch for your comments. Thanks for the review.
master: https://github.com/mozilla-b2g/gaia/commit/f56f364d7af0409729954748122d9e38a6480e82
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2 FC (16sep)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: