Closed
Bug 864363
Opened 12 years ago
Closed 12 years ago
ProfileManager calls into nsWindowWatcher without having initialized nsContentUtils
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This is the issue from bug 863646, which is now closed, because we fixed the startup crash with a backout of bug 860438. But we still need to fix this.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
I wonder if this is related to the shutdown leaks I see from running the profile manager.
|
|
Assignee | |
Comment 3•12 years ago
|
||
This patch was r+-ed on the other bug.
Attachment #740390 -
Flags: review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
It turns out that the JS engine asserts that we only ever have one JSRuntime
per thread. So when we spin up XPConnect in XPCOM initialization, we run into
assertions when this standalone test does JS_NewRuntime. FWIW, it probably
shouldn't be creating a random runtime and then passing that cx into Gecko
APIs anyway.
It sure would be nice if C++ unit tests could run with internal linkage... :-(
Attachment #740392 -
Flags: review?(benjamin)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 740392 [details] [diff] [review]
Fix standalone unit test to use the JSRuntime from XPConnect. v1
You could just make this a gtest...
Attachment #740392 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86983e77d4a5
https://hg.mozilla.org/mozilla-central/rev/756245b309a2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•