Closed
Bug 865252
Opened 11 years ago
Closed 11 years ago
Don't heavily prefer cache when loading source mapped sources
Categories
(DevTools :: Debugger, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: fitzgen, Assigned: fitzgen)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
We pretty much always get the source as it was first loaded, because even hard refreshing doesn't actually check if the original source is modified or anything.
|
Assignee | |
Comment 1•11 years ago
|
||
Fixes the bug for me, but has no test yet.
* Using the LOAD_NORMAL flag didn't fix it for me, it had to be LOAD_BYPASS_CACHE.
* Good to pass the SourceActor the whole source map, because it will need it for bug 852792 anyways
Assignee: nobody → nfitzgerald
|
|
Assignee | |
Updated•11 years ago
|
Blocks: dbg-sourcemap
|
|
Assignee | |
Comment 2•11 years ago
|
||
Rebased on top of my patch for bug 852792
Added test to ensure that if the file changes, we don't get the old version from the cache.
Attachment #741348 -
Attachment is obsolete: true
Attachment #746680 -
Flags: review?(past)
|
|
Assignee | |
Comment 3•11 years ago
|
||
And here is a try push: https://tbpl.mozilla.org/?tree=Try&rev=54ab5bb07cd1
|
|
Assignee | |
Comment 4•11 years ago
|
||
Woops, added the allowNonExistant parameter so that the console warning message won't happen and cause the tests to fail.
https://tbpl.mozilla.org/?tree=Try&rev=2d923b6182fd
Attachment #746680 -
Attachment is obsolete: true
Attachment #746680 -
Flags: review?(past)
Attachment #747021 -
Flags: review?(past)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 747021 [details] [diff] [review]
v2
Forgot that Panos is out for the week...
Attachment #747021 -
Flags: review?(past) → review?(rcampbell)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 747021 [details] [diff] [review]
v2
Review of attachment 747021 [details] [diff] [review]:
-----------------------------------------------------------------
sensible
Attachment #747021 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
||
Comment 7•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=4dbd432e7667
https://hg.mozilla.org/integration/fx-team/rev/752dca088d71
Although: "CLOSED. BuiltBot issues: jobs don't seem to be showing up; tbpl fails to finish loading; retriggers not working;."
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
|
||
Comment 8•11 years ago
|
||
Backed out for xpcshell bustage
https://hg.mozilla.org/integration/fx-team/rev/81fe6ab72d45
https://tbpl.mozilla.org/php/getParsedLog.php?id=22857908&tree=Fx-Team
I got oranged locally with either this or bug 865252 in, so I backed them both out.
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 9•11 years ago
|
||
That last comment should read: "I got oranges locally with either this or bug 852792 in, so I backed them both out."
|
|
Assignee | |
Comment 10•11 years ago
|
||
Rebased to use |attachTestTabAndResume| since the alternative no longer exists.
Attachment #747021 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
|
|
Assignee | |
Comment 11•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Priority: -- → P2
|
||
Comment 12•11 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 13•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•