Closed Bug 865287 Opened 12 years ago Closed 12 years ago

[sms] [unit tests] sms tests should use the real html from index.html

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

defect
Not set
normal

Tracking

(b2g18 fixed)

RESOLVED FIXED
1.1 CS (11may)
Tracking Status
b2g18 --- fixed

People

(Reporter: gnarf, Assigned: gnarf)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31 Steps to reproduce: The sms_test suite currently checks a bunch of html/template related things, however it is using entirely mocked data, which can diverge from the content of the index.html. We should make the unit tests load in the html from index.html
Component: General → Gaia::SMS
Comment on attachment 741356 [details] https://github.com/mozilla-b2g/gaia/pull/9384 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch:
Attachment #741356 - Flags: review?
Attachment #741356 - Flags: approval-gaia-v1?
Attachment #741356 - Flags: review?(felash)
Attachment #741356 - Flags: review?
Attachment #741356 - Flags: approval-gaia-v1?
Assignee: nobody → gnarf37
Comment on attachment 741356 [details] https://github.com/mozilla-b2g/gaia/pull/9384 reviewed on the PR github we'll try the approach and see if it works correctly. In the end I'd like to have this integrated in the main test-agent so I'd like a feedback from James too.
Attachment #741356 - Flags: feedback?(jlal)
Comment on attachment 741356 [details] https://github.com/mozilla-b2g/gaia/pull/9384 Approach looks good to me but I don't think we should upstream this to test-agent but just to the shared test code in test_apps/test-agent/... test-agent does alot right now... In my ideal world it would simply focus on running and aggregating test results and the rest (including how to include files) is up to the developer (our gaia stuff).
Attachment #741356 - Flags: feedback?(jlal) → feedback+
Target Milestone: --- → 1.1 CS (11may)
Comment on attachment 741356 [details] https://github.com/mozilla-b2g/gaia/pull/9384 r=me if you rename the new file to "load_body_html_helper.js".
Attachment #741356 - Flags: review?(felash) → review+
master: e150fb80302bebef676cf0e972bd17f83de97993
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I'll uplift it because it's npotb.
Flags: needinfo?(felash)
a=npotb v1-train: 85f283d15cebb50d0bd5119c17cf98f83f4f543c
Flags: needinfo?(felash)
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: