Closed Bug 865923 Opened 12 years ago Closed 12 years ago

Touching item in AwesomeBar ListView highlights entire list on Froyo and Gingerbread

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox21 unaffected, firefox22 verified, firefox23 verified, relnote-firefox -)

Status:
VERIFIED FIXED
Milestone:
Firefox 23
Tracking Flags:
Tracking Status
firefox21 --- unaffected
firefox22 --- verified
firefox23 --- verified
relnote-firefox --- -

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

(Whiteboard: ui-hackathon)

Attachments

(2 files)

Use solid shapes in listSelector drawables
(deleted), patch
lucasr
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Use solid shapes for inverse listSelector drawables. r=lucasr
(deleted), patch
bnicholson
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
While looking at bug 862761, I noticed that touching an entry in any of the AwesomeBar lists highlights the entire list instead of just the entry being touched. I'm surprised I couldn't find this bug filed already -- maybe it's a device-specific bug?
Another workaround. This uses the solution posted at http://stackoverflow.com/a/5155600/1524401. By the way, I'm seeing this on a Samsung Galaxy S, Android 2.2.2.
Attachment #742095 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 742095 [details] [diff] [review] Use solid shapes in listSelector drawables I see it on Gingerbread too, on my Nexus S.
Summary: Touching item in AwesomeBar ListView highlights entire list on Froyo → Touching item in AwesomeBar ListView highlights entire list on Froyo and Gingerbread
I'm actually seeing this on Aurora as well.
status-firefox22: unaffected → affected
Comment on attachment 742095 [details] [diff] [review] Use solid shapes in listSelector drawables Review of attachment 742095 [details] [diff] [review]: ----------------------------------------------------------------- Classic. You should probably do the same on action_bar_button_inverse.xml while on it.
Attachment #742095 - Flags: review?(lucasr.at.mozilla) → review+
Comment on attachment 742095 [details] [diff] [review] Use solid shapes in listSelector drawables [Approval Request Comment] Bug caused by (feature/regressing bug #): unknown User impact if declined: entire list changes color when touched Testing completed (on m-c, etc.): locally Risk to taking this patch (and alternatives if risky): very low String or IDL/UUID changes made by this patch: none
Attachment #742095 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/593f81bc7752
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Oops, forgot the second part to address comment 6. https://hg.mozilla.org/integration/mozilla-inbound/rev/3c8ec2c615bb [Approval Request Comment] See above.
Attachment #743756 - Flags: review+
Attachment #743756 - Flags: approval-mozilla-aurora?
Attachment #742095 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #743756 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
status-firefox23: fixed → verified
Verified fixed on: -build: Firefox for Android 22 Beta 2 -Device: Samsung Galaxy S2 -OS: Android 4.0.3
status-firefox22: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: