Closed
Bug 866135
Opened 12 years ago
Closed 12 years ago
Contacts: Fully integrate PhonenumberJS when we save contacts
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
People
(Reporter: reuben, Assigned: gwagner)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(2 files, 2 obsolete files)
|
(deleted),
patch
|
reuben
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•12 years ago
|
||
We don't need to store both versions because filterValue was being normalized before searching. Also includes some cleanup of makeImport.
Attachment #742399 -
Flags: review?(anygregor)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #742399 -
Flags: review?(anygregor)
|
|
Reporter | |
Comment 2•12 years ago
|
||
Attachment #742399 -
Attachment is obsolete: true
Attachment #742401 -
Flags: review?(anygregor)
|
|
Reporter | |
Updated•12 years ago
|
Attachment #742401 -
Attachment is obsolete: true
Attachment #742401 -
Flags: review?(anygregor)
|
Assignee | |
Updated•12 years ago
|
Summary: Contacts: |search.tel| should be normalized → Contacts: Fully integrate PhonenumberJS when we save contacts
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Blocks: b2g-contact
|
|
Assignee | |
Comment 4•12 years ago
|
||
We didn't fully integrate PhoneNumberJS when saving contacts. The problem is when we import contacts from other sources like google or facebook. The numbers can contain random spaces that we can't enter with our keyboard.
This patch allows us to handle lookups for such contacts correctly.
blocking-b2g: --- → leo?
|
|
Reporter | |
Updated•12 years ago
|
Assignee: reuben.bmo → anygregor
|
|
Assignee | |
Updated•12 years ago
|
Attachment #742450 -
Flags: review?(reuben.bmo)
|
|
Reporter | |
Comment 5•12 years ago
|
||
Comment on attachment 742450 [details] [diff] [review]
patch
Review of attachment 742450 [details] [diff] [review]:
-----------------------------------------------------------------
This is a happy day for ContactDB.makeImport! :)
Attachment #742450 -
Flags: review?(reuben.bmo) → review+
|
|
Reporter | |
Comment 6•12 years ago
|
||
Whiteboard: [fixed-in-birch]
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
||
Comment 10•12 years ago
|
||
This is going to need a branch-specific patch for uplift.
|
|
||
Updated•12 years ago
|
Flags: needinfo?(anygregor)
|
|
Assignee | |
Comment 11•12 years ago
|
||
Flags: needinfo?(anygregor)
|
|
||
Comment 12•12 years ago
|
||
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-firefox21:
--- → wontfix
status-firefox22:
--- → wontfix
status-firefox23:
--- → fixed
|
||
Updated•11 years ago
|
Flags: in-moztrap-
You need to log in
before you can comment on or make changes to this bug.
Description
•