STR: 1) Load https://www.getpersonas.com/en-US/update_check/154970 (an updateURL for a theme from getpersonas.com). Note that the persona ID is 154970 Expected result: "id" property in the update JSON should be "154970" Actual result: "id" property in the update JSON is "116211" Firefox ensures that an update is for the same theme by checking that the ID matches[1]. We should ensure that updates continue to work for themes installed from AMO. I believe the update body is already correct for them. [1] https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/LightweightThemeManager.jsm?rev=dc6c1d4bff95&mark=206#180

`154970` is the legacy `persona_id` from getpersonas. On AMO, you can look up a theme by its legacy `persona_id`: https://addons.mozilla.org/persona/154970 That theme's `addon_id` is `116211`. https://addons.mozilla.org/en-US/firefox/addon/red_abstract/ https://addons.mozilla.org/en-US/firefox/addon/116211/ Notice that from getpersonas we are looking up https://versioncheck.addons.mozilla.org/en-US/themes/update-check/<persona_id>?src=gp Then upon update we hit https://versioncheck.addons.mozilla.org/en-US/themes/update-check/<addon_id> This is so we can remove all references to `persona_id`. What does this break?

I understand all of this but when we have the ?src=gp on the update URL, we need to use the legacy id in the JSON returned by the server or Firefox will think it's getting the update for the wrong theme and refuse to update. See [1].

Just want to note that this may make it harder for metrics to track usage since they may need to check both addon_id and persona_id URLs and combine the # of users IIUC.

Fixed on AMO. We can probably push this to production soonish. https://github.com/mozilla/zamboni/commit/aefb3f48b0

Chris, it looks like this went live and the bug can be closed, right?