Closed
Bug 866564
Opened 12 years ago
Closed 12 years ago
Don't cache Lightweight Theme update checks
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
For parity with XPI and application updates and to prevent accidentally blocking all theme updates by getting an update entry stuck in the cache (e.g. bug 861481), we should avoid caching the result of pinging the updateURL.
Attachment #742892 -
Flags: review?(bmcbride)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 742892 [details] [diff] [review]
v.1 Use LOAD_BYPASS_CACHE and INHIBIT_CACHING
Review of attachment 742892 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good (and you made me file bug 866636).
Attachment #742892 -
Flags: review?(bmcbride) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks!
(In reply to Blair McBride [:Unfocused] (Back from the dead. Mostly.) from comment #1)
> Looks good (and you made me file bug 866636).
I was waiting to file that bug until I saw what the thinking was on this one :)
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/efe2917fb849
Try results: https://tbpl.mozilla.org/?tree=Try&rev=373923c7d2bb
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•