Closed
Bug 866778
Opened 11 years ago
Closed 11 years ago
GC: Make autorooter for HashableValue contain its value
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Change HashableValue::AutoRooter to AutoHashableValueRooter and make it contain its HashableValue rather than a pointer to it. This fixes the rooting hazards reported in MapObject.cpp
Attachment #743145 -
Flags: review?(sphink)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 743145 [details] [diff] [review]
Proposed changes
Review of attachment 743145 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/gc/RootMarking.cpp
@@ +626,2 @@
> {
> + MarkValueRoot(trc, reinterpret_cast<Value*>(&value), "HashableValue::AutoRooter");
doc string should be "AutoHashableValueRooter" now
Attachment #743145 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•