Jason Smith [:jsmith] Reporter
	Description • 11 years ago

At some point, orientation lock was working for web apps, but it definitely isn't working now. 

Critical to fix given that we've got apps (including packaged apps) that will only run in landscape orientation.

Example of a good app to test this with is "Packaged App Test Case 20" on http://mozqa.com/webapi-permissions-tests/ - which happens to be Poppit.

	Jason Smith [:jsmith] Reporter
	Comment 1 • 11 years ago

https://developer.mozilla.org/en-US/docs/Apps/Manifest#orientation

	Jason Smith [:jsmith] Reporter
	Comment 2 • 11 years ago

Example screenshot of what happens when we don't care about orientation lock.

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 3 • 11 years ago

Wes worked on this previously

	Wesley Johnston (:wesj) Assignee
	Comment 4 • 11 years ago

Likely fixed by bug 856131.

	Aaron Train [:aaronmt]
	Comment 5 • 11 years ago

Fixed via 856131; but there's a really awful bug still where content doesn't stretch to the device width http://cl.ly/image/0i1S0c1j0S0E

	Jason Smith [:jsmith] Reporter
	Comment 6 • 11 years ago

This isn't fixed for me on a Galaxy Nexus on a 5/11 Nightly build. Reopening.

	Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)
	Comment 7 • 11 years ago

Wes, Aaron, any ideas why Jason isn't seeing this fixed in Nightly?

	Aaron Train [:aaronmt]
	Comment 8 • 11 years ago

Nope. I see this too.

	Wesley Johnston (:wesj) Assignee
	Comment 9 • 11 years ago

Packaged app 20's manifest is http://mozqa.com/webapi-permissions-tests/poppit.manifest I think? It doesn't include an orientation lock line. What are they using?

	Jason Smith [:jsmith] Reporter
	Comment 10 • 11 years ago

(In reply to Wesley Johnston (:wesj) from comment #9)
> Packaged app 20's manifest is
> http://mozqa.com/webapi-permissions-tests/poppit.manifest I think? It
> doesn't include an orientation lock line. What are they using?

That's the mini-manifest, which won't include orientation lock in it. You need to look at the webapp manifest in the root of the zip archive. You'll see the following:

{
    "name": "Poppit!™",
	"version": "1.0.1",
    "description": "The prickly puzzle game where popping balloons has never been so much fun! Pop colorful strings of balloons to earn a bonus!",
    "launch_path": "/index.html",
    "icons": {
        "30": "/img/freeballoon-30.png",
        "60": "/img/freeballoon-60.png",
		"128": "/img/Poppitlogo.png"
    },
    "developer": {
        "name":"Electronic Arts",
        "url":"http://www.ea.com"
    },
    "default_locale": "en",
    "fullscreen": "true",
    "orientation": ["landscape"]
}

	Wesley Johnston (:wesj) Assignee
	Comment 11 • 11 years ago

Ahh, well then this has always been broken for packaged apps. Lets rename this bug to something more descriptive.

	Wesley Johnston (:wesj) Assignee
	Comment 12 • 11 years ago

Wanted to get james used to reviewing as well (and maybe this is some code you haven't looked at before). There were some layers of problems here (and I cleaned up a little on the way too).

1.) We were saving this info using the wrong manifest for packaged apps
2.) We weren't updating the correct webapp index during install, so we would up writing prefs into a different profile than the one we launched with
3.) orientations is really an array of possible values.

I also cleaned up an error that would scroll by setting the origin for "app" protocol apps in java (used only to determine if we should show a titlebar or not), and renamed uniqueURI to origin to make the code a little clearer to me as to what it was doing.

	Wesley Johnston (:wesj) Assignee
	Comment 13 • 11 years ago

Pinging james and mfinkle?

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 14 • 11 years ago

Comment on attachment 757605 [details] [diff] [review]
Patch

The whole "origin" and "originalOrigin" is a bit confusing, but the one single comment in browser.js helps explain it. You might want to add some comments in postInstallWebApp as to why "originalOrigin" even exists.

	Wesley Johnston (:wesj) Assignee
	Comment 15 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a905d1c9b37

	Phil Ringnalda (:philor)
	Comment 16 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/7a905d1c9b37

	James Hugman [:jhugman] [@jhugman]
	Comment 17 • 11 years ago

Removing out of date flags.