Closed
Bug 866790
Opened 11 years ago
Closed 11 years ago
[B2G] [Inari] [Camera] Pictures are compressed along the narrow axis after they are taken
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(blocking-b2g:leo+, b2g18 fixed)
Tracking | Status | |
---|---|---|
b2g18 | --- | fixed |
People
(Reporter: ckreinbring, Assigned: daleharvey)
References
Details
(Keywords: smoketest, Whiteboard: c=)
Attachments
(2 files)
Description:
Any pictures that are taken are given a small amount of vertical compression immediately afterwards.
Repro Steps:
1) Updated to Inari Build ID: 20130429070204
2) Launch the camera app.
3) Take a picture and observe the appearance of the picture taken.
Actual:
The picture is vertically compressed shortly after it is taken.
Expected:
The dimensions of the picture is unchanged after it is taken.
Environmental Variables:
Occurs on the Inari device
Build ID: 20130429070204
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2
Version #: 18.0
Notes:
Repro frequency: 100%
Test Suite Name: Firefox OS Daily Smoketest
UCID: Daily Smoketest
Link to failed test case: https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=1325
Q Analysts Test Team Priority: Pri 3
See attached logcat logs for more info.
Updated•11 years ago
|
Summary: [B2G] [Inari] [Camera] Pictures are vertically compressed after they are taken → [B2G] [Inari] [Camera] Pictures are compressed along the narrow axis after they are taken
Updated•11 years ago
|
blocking-b2g: --- → tef?
tracking-b2g18:
--- → ?
Comment 1•11 years ago
|
||
From the inari logcat:
V( 117:0x75) requested preview size 480 x 320
V( 117:0x75) requested picture size 1600 x 1200
V( 117:0x75) requested jpeg thumbnail size 512 x 384
Preview size (and the display size) is 3:2, and picture size is 4:3, which seems to be the size applied to the "postview" frame on the inari. This will result in a postview that is squished along the narrow axis, assuming the long axis remains the same.
dale, can we adjust the style of the viewfinder element to make it fill without distorting the aspect ratio?
Flags: needinfo?(dale)
Assignee | ||
Comment 2•11 years ago
|
||
Yup this has been a long needed change, will have a patch for it shortly
Assignee: nobody → dale
Flags: needinfo?(dale)
Updated•11 years ago
|
tracking-b2g18:
? → ---
Note: landscape will show the image in the same res in landscape.
Updated•11 years ago
|
Whiteboard: [tef-triage]
Comment 4•11 years ago
|
||
preview being shown in a different ratio isn't a blocker.
blocking-b2g: tef? → -
Whiteboard: [tef-triage] → c=
Assignee | ||
Comment 5•11 years ago
|
||
Doh, as far as I can tell the previous patch never landed (and if I remember there were problems with the hardware honoring the set size)
There isnt a thumbnailSizes in camera.capabilities right now at least, although looking through the code 'some' of it must have landed
Depends on: 807058
Assignee | ||
Comment 6•11 years ago
|
||
The rotation setting wasnt currently being used so I took it out, this also fixed https://bugzilla.mozilla.org/show_bug.cgi?id=871904 however there are other bugs visible on the leo device so will file seperately
Attachment #750630 -
Flags: review?(dflanagan)
Comment 8•11 years ago
|
||
Comment on attachment 750630 [details]
Pointed to GH
I haven't had a chance to try the code out yet, but am giving r- because I don't understand the math being used to position the viewfinder object. See my comments on github. I'll finish reviewing when you alter or comment the math.
Attachment #750630 -
Flags: review?(dflanagan) → review-
Comment 9•11 years ago
|
||
I partially get the math now, and have updated my github comments.
Assignee | ||
Comment 10•11 years ago
|
||
Comment on attachment 750630 [details]
Pointed to GH
Updated the viewfinder logic, I think it is a lot clearer right now. Made a few other changes based on the comments, Tested on inari and leo.
We will have a slight edge to the right or bottom of the preview in which extra data will be captured in the final picture, but it is small enough I didnt see it worth adding the code to center it (and it is expected that cameras capture a little more than is in the preview)
Attachment #750630 -
Flags: review- → review?
Assignee | ||
Updated•11 years ago
|
Attachment #750630 -
Flags: review? → review?(dflanagan)
Comment 11•11 years ago
|
||
Comment on attachment 750630 [details]
Pointed to GH
r+ if you fix the new comments on github. A couple are just nits. One is an error in an else clause that will probably never run. But I've also suggested code you can use to center the viewfinder. I think it is worth doing that because otherwise a full 1/8th of the frame is off the right side.
Attachment #750630 -
Flags: review?(dflanagan) → review+
Comment 12•11 years ago
|
||
A nice thing about this patch is that it cures the graphical garbage screen that was always displayed on unagi after taking a picture!
Assignee | ||
Comment 13•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 14•11 years ago
|
||
Setting target milestone and nominating for leo because the duplicate bug 871904 was a leo qe2 bug. The symptom in 871904 sounds pretty serious on Leo hardware, so I think this fix really needs to be uplifted.
blocking-b2g: - → leo?
Target Milestone: --- → 1.1 QE2
Comment 15•11 years ago
|
||
hey, you broke the linter, could you please make a quick follow up to fix it ?
Updated•11 years ago
|
Flags: needinfo?(dale)
Assignee | ||
Comment 16•11 years ago
|
||
Apologies, followed up and merged in: https://github.com/mozilla-b2g/gaia/pull/9860
Flags: needinfo?(dale)
Comment 17•11 years ago
|
||
new commit master hash is 292f6c2fba2729c81a304c65597ed20efca45d2e
thanks dale !
Comment 19•11 years ago
|
||
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with:
git checkout v1-train
git cherry-pick -x -m1 292f6c2fba2729c81a304c65597ed20efca45d2e
<RESOLVE MERGE CONFLICTS>
git commit
Comment 20•11 years ago
|
||
Gaye, there are 2 commits here:
1. a80a08c71f111344fda673f1a2b6475484f6efa4
2. 292f6c2fba2729c81a304c65597ed20efca45d2e
Flags: needinfo?(gaye)
Comment 23•11 years ago
|
||
Uplifted 292f6c2fba2729c81a304c65597ed20efca45d2e to:
v1-train: b28e941caf486a0fe8d6af1a9cde670c5638de2c
status-b2g18:
--- → fixed
Flags: needinfo?(gaye)
Updated•11 years ago
|
Flags: in-moztrap?
Comment 24•11 years ago
|
||
UCID: camera-001
TC link: https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=1325
Flags: in-moztrap? → in-moztrap+
Reporter | ||
Comment 25•11 years ago
|
||
Still repros on Inari 1.0.1 commercial RIL.
Build ID: 20130620070212
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 93241eb6c5d6c110710fad8da3ccd4423312b0c9
Platform Version: 18.0
Reporter | ||
Comment 26•11 years ago
|
||
Still repros on Inari 1.0.1 commercial RIL
Build ID: 20130722070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 054cdc27404e2daca91d3065d9783681032b2151
Platform Version: 18.0
RIL Version: 01.00.01.019.144
Reporter | ||
Comment 27•11 years ago
|
||
Photos are still compressed on Inari 1.0.1 commercial RIL.
Build ID: 20130816043204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 054cdc27404e2daca91d3065d9783681032b2151
Platform Version: 18.0
RIL Version: 01.00.01.019.144
Comment 28•11 years ago
|
||
ckreinbring> this is not fixed in 1.0.1, this is fixed in 1.1 only :)
You need to log in
before you can comment on or make changes to this bug.
Description
•