Closed
Bug 867012
Opened 12 years ago
Closed 12 years ago
b2g mozconfigs need to opt in to AUTOCLOBBER=1
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: dhylands)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Bug 863091 made automatic clobbering when /CLOBBER is touched only happen for builds which opt in in their mozconfig by exporting AUTOCLOBBER=1.
b2g builds appear to have mozconfigs, but they appear to live in some other tree, so they didn't get opted in, though they still have the configure check which causes them to burn whenever /CLOBBER is touched.
Comment 1•12 years ago
|
||
I'm guessing somewhere here:
https://github.com/mozilla-b2g/gaia/blob/master/Makefile#L74
(though the comment implies that would affect local user builds too)
Or else via buildbot/mozharness?
Comment 2•12 years ago
|
||
Some B2G mozconfigs for buildbot are here: http://mxr.mozilla.org/mozilla-central/source/b2g/config/mozconfigs/
The mozconfig used for device builds is here: https://github.com/mozilla-b2g/gonk-misc/blob/master/default-gecko-config
Comment 3•12 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #2)
> Some B2G mozconfigs for buildbot are here:
> http://mxr.mozilla.org/mozilla-central/source/b2g/config/mozconfigs/
>
> The mozconfig used for device builds is here:
> https://github.com/mozilla-b2g/gonk-misc/blob/master/default-gecko-config
The former pulls in the global common mozconfig (http://hg.mozilla.org/mozilla-central/file/3fb2370f4871/b2g/config/mozconfigs/common) - so will include my change. Guessing the latter is what we are missing.
Comment 4•12 years ago
|
||
Bump (I don't have gaia access) - burnt more builds today because of this bug.
Assignee | ||
Comment 5•12 years ago
|
||
So, I'm guessing then, that the right fix is to add:
. "$topsrcdir/b2g/config/mozconfigs/common"
to the top of gonk-misc/default-gecko-config?
Comment 6•12 years ago
|
||
(In reply to Dave Hylands [:dhylands] from comment #5)
> So, I'm guessing then, that the right fix is to add:
>
> . "$topsrcdir/b2g/config/mozconfigs/common"
>
> to the top of gonk-misc/default-gecko-config?
Flags: needinfo?(jgriffin)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dhylands
Updated•12 years ago
|
Attachment #748974 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 9•12 years ago
|
||
Merged into gonk-misc/master:
https://github.com/mozilla-b2g/gonk-misc/commit/917cb23483a02eb70d5b86a1a4d2eae65adab2d4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•