We only use this on Gtk/Linux, and this complicates bug 866731 where we want to use compositor animation and a color layer to animate the caret. Even on Gtk we probably really want that optimization, so I would say this code path is worth of wholesale deletion (I can make 866731 work with this code in place, but I think the right thing to do is to delete it).

Note: even on gtk we don't use the widget code to draw the caret if the textfield color is non-standard (CSS set), which is probably pretty much always these days.

Actually I will leave the NS_THEME_TEXTFIELD_CARET constant itself. A CSS property depends on it and I don't feel lucky enough to mess with that.

Comment on attachment 743473 [details] [diff] [review] remove NS_THEME_TEXTFIELD_CARET and gtk implementation of it Review of attachment 743473 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense.