Andreas Gal :gal Assignee
	Description • 11 years ago

We only use this on Gtk/Linux, and this complicates bug 866731 where we want to use compositor animation and a color layer to animate the caret. Even on Gtk we probably really want that optimization, so I would say this code path is worth of wholesale deletion (I can make 866731 work with this code in place, but I think the right thing to do is to delete it).

	Andreas Gal :gal Assignee
	Comment 2 • 11 years ago

Note: even on gtk we don't use the widget code to draw the caret if the textfield color is non-standard (CSS set), which is probably pretty much always these days.

	Andreas Gal :gal Assignee
	Comment 3 • 11 years ago

Actually I will leave the NS_THEME_TEXTFIELD_CARET constant itself. A CSS property depends on it and I don't feel lucky enough to mess with that.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 4 • 11 years ago

Comment on attachment 743473 [details] [diff] [review]
remove NS_THEME_TEXTFIELD_CARET and gtk implementation of it

Review of attachment 743473 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

	Andreas Gal :gal Assignee
	Comment 5 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb8ae1b71f3f

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/fb8ae1b71f3f