Closed Bug 867290 Opened 12 years ago Closed 5 years ago

Focusing the search bar leaks an nsDocShell

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jruderman, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: memory-leak, Whiteboard: [MemShrink:P2])

1. Ctrl+K
2. Ctrl+W

or

1. Click the search bar
2. Click the corner 'x' to close the window

Result: Leak nsDocShell

Performing a search between the steps seems to make the leak go away.

(Reported on Windows, but also reproduced on Mac.)
Assignee: nobody → continuation
Whiteboard: [MemShrink] → [MemShrink:P2]
Wild guess: autocomplete.xml's detachController isn't being called in this case (no blur event), so the autocomplete controller holds on to the search bar's docshell via its reference to the search input.
Blurring between the steps does not make the leak go away.
The docshell that is leaking has id=2.  I haven't been able to figure out anything else useful yet...
Blocks: fuzz-keys
Assignee: continuation → nobody
Hi.
After some search in nsDocShell the method DoFindItemWithName() seems to be responsible for search field; concluding from its name. Am I on the right way?
This bug is about the search field, not the find toolbar, so comment 5 is not relevant.

The current mochitests aren't showing leaks, and I've just tried this on Mac and can't reproduce. So I think this is WFM now.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.