Closed
Bug 867472
Opened 12 years ago
Closed 12 years ago
Nuke unnecessary screenshot assets from app listing pages (home/category)
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-05-09
People
(Reporter: spasovski, Assigned: spasovski)
References
()
Details
(Whiteboard: [fireplace] p=2)
The network load of unused images is insane. Thanks for finding this Basta.
1. Load homepage.
2. Open the network tab in your favorite debugger.
3. Notice all the screenshots being requested and never used.
Fix this and watch the subsequent delirious joy.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dspasovski
Whiteboard: [fireplace] p=2
Comment 1•12 years ago
|
||
This is P1, IMO. This causes upwards of 1MB of bandwidth on each uncached category hit.
Priority: -- → P1
Comment 2•12 years ago
|
||
This is because we're using the listing style on mobile version of the category landing pages/homepage, but we never allow the user to toggle to the graphical view - it's always the list view. This is my bad - we should fix this in our call when we render the `market_title.html` template.
Comment 3•12 years ago
|
||
This begs the question though ...
I've been doing `display: none` on the screenshot trays. If we're loading the list view by default for mobile and the screenshots are hidden by the default, and evidently we're still making HTTP requests to fetch these images, that's penalizing our mobile users. We might want to lazy load these instead of using straight <img> tags. Hmm ...
Updated•12 years ago
|
Summary: nuke unnecessary screenshot assets from app listing pages (home/category) → Nuke unnecessary screenshot assets from app listing pages (home/category)
Assignee | ||
Comment 4•12 years ago
|
||
this should do it:
https://bugzilla.mozilla.org/show_bug.cgi?id=867472
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•12 years ago
|
||
umm...i meant: https://github.com/mozilla/fireplace/commit/871f756
Updated•12 years ago
|
Target Milestone: --- → 2013-05-09
You need to log in
before you can comment on or make changes to this bug.
Description
•