Closed Bug 867637 Opened 12 years ago Closed 12 years ago

Disable dynamic toolbar in Firefox 22

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

Product:
Firefox for Android Graveyard
Component:
Toolbar
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox22+ disabled)

Status:
VERIFIED FIXED
Milestone:
Firefox 22
Tracking Flags:
Tracking Status
firefox22 + disabled

People

(Reporter: cwiiis, Assigned: cwiiis)

Details

Attachments

(1 file)

Disable dynamic toolbar via prefs
(deleted), patch
kats
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
I think it's generally agreed that there has been too much work done on the dynamic toolbar to safely merge it all to Aurora, and there's still some ongoing work. All in all, it would be safer to disable this in 22 and let the extra work ride the trains.
Attachment #744168 - Flags: review?(bugmail.mozilla)
Attachment #744168 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 744168 [details] [diff] [review] Disable dynamic toolbar via prefs [Approval Request Comment] Bug caused by (feature/regressing bug #): Blocking bugs of bug 716403 User impact if declined: Glitchy behaviour with dynamic toolbar Testing completed (on m-c, etc.): Tested locally, just disables pref Risk to taking this patch (and alternatives if risky): Low risk String or IDL/UUID changes made by this patch: None
Attachment #744168 - Flags: approval-mozilla-aurora?
Given the number of tracked bugs, this makes sense to me. Please make sure to mark the status flags in bug 716403 properly as well.
tracking-firefox22: --- → +
relnote-firefox: --- → ?
Target Milestone: --- → Firefox 22
(In reply to Chris Lord [:cwiiis] from comment #2) > Comment on attachment 744168 [details] [diff] [review] > Disable dynamic toolbar via prefs > > [Approval Request Comment] (In reply to Alex Keybl [:akeybl] from comment #3) > Given the number of tracked bugs, this makes sense to me. Please make sure > to mark the status flags in bug 716403 properly as well. Missed a +
Did you mean to a+?
Flags: needinfo?(akeybl)
Attachment #744168 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Argh, thought I'd pushed this ages ago... https://hg.mozilla.org/releases/mozilla-aurora/rev/c8171498a265
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-firefox22: --- → fixed
Flags: needinfo?(akeybl)
Resolution: --- → FIXED
Verified fixed on: -build: Firefox for Android 22.0a2(2013-05-13) -device: Samsung Galaxy Nexus -OS: Android 4.1.1
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: