Julien pointed out to me yesterday that if we don't hold the CPU wake lock when we receive an incoming SMS, the device might not stay awake long enough to notify the user. This is a simple patch; I'll send a PR in a sec.

Pointer to Github pull-request

tef? because not notifying the user of a new SMS is bad.

I would like to request a test, but since there is no activity_handler_test now I don't want to ask you the overhead of creating that file. Would you please file a bug about writing a test for this and assigning it to me ?

Comment on attachment 744184 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9499 stealing, r=me

I wonder if that could fix the bug "sometimes sms take a very long time to be 'received'" that we saw in the feedbacks.

Thanks for not making me write a test. :) I merged this despite Travis failures, which seem totally unrelated. I hope that's the right thing to do. https://github.com/mozilla-b2g/gaia/commit/e9b649b29602e571ef96892f62fc52fb19364639 > I wonder if that could fix the bug "sometimes sms take a very long time to be 'received'" that we > saw in the feedbacks. Could be; perhaps you could make those bugs (are there bugs?) depend on this one.

Comment on attachment 744184 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9499 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: we might not get the new SMS notification Testing completed: yes Risk to taking this patch (and alternatives if risky): low, this won't change any core functionality String or UUID changes made by this patch: none

tef+ so that you don't need approval. Thanks! btw, should not we mark this as FIXED?

I guess we mark things as FIXED when they land in Gaia master? I don't land patches there very often, so I don't know.

Uplifted e9b649b29602e571ef96892f62fc52fb19364639 to: v1-train: 50ccc9363e6bd7f124f2febba11d1b3cd570570e v1.0.1: 9d7408aa8320ff40aefd598a9b7aac9dc110a874

(In reply to Justin Lebar [:jlebar] from comment #9) > I guess we mark things as FIXED when they land in Gaia master? I don't land > patches there very often, so I don't know. Yep, just like moz central :)

Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?

Can you please provide steps to verify this fix - as we can perform blackbox testing from the UI?

quite difficult to verify, sorry.