Closed
Bug 868150
Opened 12 years ago
Closed 12 years ago
Add basic support for supporting another gonk base version (JB)
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: mwu, Assigned: mwu)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This patch allows us to identify different gonk versions and change the build accordingly. Some basic bits necessary for JB support on the build side are here, along with reducing the number of include paths directly specified in configure.in. I have other patches on the way that will reduce the number of include paths in configure.in on ICS builds.
Assignee | ||
Updated•12 years ago
|
Attachment #744795 -
Flags: review?(mh+mozilla)
Comment 1•12 years ago
|
||
Comment on attachment 744795 [details] [diff] [review]
Add basic support for identifying and building for JB
Review of attachment 744795 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +209,5 @@
> + 17)
> + GONK_INCLUDES="-I$gonkdir/frameworks/native/include"
> + ;;
> + *)
> + AC_MSG_ERROR([Unsupported platform version: \$ANDROID_VERSION])
Does that really work with the backslash?
Attachment #744795 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1)
> Comment on attachment 744795 [details] [diff] [review]
> Add basic support for identifying and building for JB
>
> Review of attachment 744795 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: configure.in
> @@ +209,5 @@
> > + 17)
> > + GONK_INCLUDES="-I$gonkdir/frameworks/native/include"
> > + ;;
> > + *)
> > + AC_MSG_ERROR([Unsupported platform version: \$ANDROID_VERSION])
>
> Does that really work with the backslash?
You're right - it doesn't. I was just copying some other code here and didn't realize they meant to print $VARNAME rather than the actual variable. Thanks
Assignee | ||
Comment 3•12 years ago
|
||
Whiteboard: [fixed-in-birch]
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•