Closed Bug 868497 Opened 12 years ago Closed 11 years ago

Movistar Recomienda's app manifest is invalid, so orientation lock will fail as a result

Categories

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jsmith, Unassigned)

Details

(Whiteboard: [apps watch list1])

The preinstalled app - movistar recomienda has an invalid app manifest - orientation does not belong under the permissions property. { "name": "Recomienda", "description": "Recomendador de app y servicios de Movistar", "version": "1.0", "launch_path": "/index.html", "developer": { "name": "Movistar", "url": "http://www.movistar.es" }, "default_locale": "es", "locales": { "es": { "name": "Recomienda", "description": "Recomendador de app y servicios de Movistar", "developer": { "name": "Movistar", "url": "http://www.movistar.es" } } }, "icons": { "128": "/style/icons/icon_128.png", "60": "/style/icons/icon_60.png" }, "permissions": { "geolocation": { "description": "Required to customize the aplication list to the final customer" }, "orientation": "portrait-primary" } } This exists both in the hosted app manifest and the app preinstalled on device: - http://www.movistarrecomienda.es/app/manifest.webapp - https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/external-apps/recomienda/manifest.webapp
Not sure how critical this is for the app to have orientation lock. Will nom defensively just in case.
blocking-b2g: --- → tef?
This requires a fix on the app developer's side and changes to the preinstalled app repository to fix this. Karen - Can someone do some outreach here to fix this problem?
Flags: needinfo?(kward)
I think Yuren is the one doing this usually.
Flags: needinfo?(yurenju.mozilla)
I prefer update manifest from 3rd party developer then we re-generate repository again. BTW, rex wrote a makefile[1] for generating external-app/* to make life easier. https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/Makefile
Flags: needinfo?(yurenju.mozilla)
Whiteboard: [customization]
So yuren this should be assigned to you ?
Sure. Karen, please contact 3rd party developer for updating their manifest.
Assignee: nobody → yurenju.mozilla
Developer notified. Also note that this app has not yet passed app review. It was last submitted on April 22 and rejected on April 25.
Flags: needinfo?(kward)
Whiteboard: [customization] → [customization][apps watch list1]
I can modify manifest on firefoxos-gaia-spain, but it will be replaced when we re-generate all apps.
Fixed. https://github.com/telefonicaid/firefoxos-gaia-spain/commit/97d8aa30dd1a996d2b498c6547eb70881349b306 Karen, please make sure 3rd party developer know this problem.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(kward)
Resolution: --- → FIXED
(In reply to Yuren Ju [:yurenju] from comment #9) > Fixed. > > https://github.com/telefonicaid/firefoxos-gaia-spain/commit/ > 97d8aa30dd1a996d2b498c6547eb70881349b306 > > Karen, please make sure 3rd party developer know this problem. see comment #7
Flags: needinfo?(kward)
Note that this only fixed on the partner app customization, not in the hosted app. So right now, given that we update very quickly, this won't do anything as a stand-alone. Reopening on that basis to await the update on the app developer's side.
Status: RESOLVED → REOPENED
blocking-b2g: tef? → ---
Resolution: FIXED → ---
Component: Gaia → Preinstalled B2G Apps
Product: Boot2Gecko → Tech Evangelism
Version: unspecified → Trunk
Assignee: yurenju.mozilla → nobody
Whiteboard: [customization][apps watch list1] → [apps watch list1]
This app has been pulled from the grid.
Status: REOPENED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → WONTFIX
No longer blocks: b2g-recomendia
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.