Closed
Bug 868548
Opened 12 years ago
Closed 12 years ago
Invalid forms should (e.g., Report Abuse) should not be submittable
Categories
(Marketplace Graveyard :: Consumer Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2013-05-09
People
(Reporter: krupa.mozbugs, Assigned: spasovski)
References
Details
(Whiteboard: [fireplace])
Attachments
(1 file)
|
(deleted),
image/png
|
Details |
screenshot
steps to reproduce:
1. Load https://marketplace-altdev.allizom.org/app/twitter/abuse
2. Enter some comments and click Submit
observed behavior:
The form submission success message shows up but the infut field hightlights in red. See screenshot.
The submission returns a 201
|
||
Updated•12 years ago
|
Blocks: 859511
Summary: Report Abuse input field highlights in red after form submission → Invalid forms should (e.g., Report Abuse) should not be submittable
|
||
Comment 1•12 years ago
|
||
Davor: also please apply your toggle form fields patch to this, keeping in mind this patch:
https://github.com/mozilla/fireplace/commit/3e11a02bf
Assignee: nobody → dspasovski
|
|
||
Comment 2•12 years ago
|
||
The fix for this is to navigate away from the form after submission. You can (in the process) remove the code in views/abuse that clears the form after submission.
Note that how you get the URL in there is probably going to be terrible (another data attribute, probably). I might even consider ditching edna's macro nonsense in this case.
|
Assignee | |
Comment 3•12 years ago
|
||
I don't disagree with adding toggle fields or with navigating away upon submission but I can't repro this locally using chimney (or not using chimney).
|
|
||
Comment 4•12 years ago
|
||
Submit a report and then submit another blank one
|
|
Assignee | |
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Target Milestone: --- → 2013-05-09
|
||
Comment 6•12 years ago
|
||
Verified as fixed in https://marketplace-altdev.allizom.org on FF23 (Win 7).
Postfix screencast http://screencast.com/t/74uPIq8C
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•