Comment on attachment 745603 [details] [diff] [review] Patch (v1) Review of attachment 745603 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks for doing this! ::: js/jsd/jsd_val.cpp @@ +610,5 @@ > return NULL; > > obj = js::UncheckedUnwrap(JSVAL_TO_OBJECT(jsdval->val)); > oldCompartment = JS_EnterCompartment(jsdc->dumbContext, obj); > fun = JS_ValueToFunction(jsdc->dumbContext, OBJECT_TO_JSVAL(obj)); Nit: can use `cx` in these two calls, too @@ +720,5 @@ > oldCompartment = JS_EnterCompartment(jsdc->dumbContext, obj); > jsdval->className = JS_GetDebugClassName(obj); > JS_LeaveCompartment(jsdc->dumbContext, oldCompartment); > JS_EndRequest(jsdc->dumbContext); > } `cx` in all of these ::: js/jsd/jsd_xpc.cpp @@ +2544,5 @@ > nsresult rv; > nsCOMPtr<nsIXPConnect> xpc = do_GetService(nsIXPConnect::GetCID(), &rv); > if (NS_FAILED(rv)) > return rv; > Not that there's too much to save here in terms of formatting, but you might just as well remove the extra whitespace while you're here.