Closed
Bug 869156
Opened 11 years ago
Closed 11 years ago
Cannot reshow dynamic toolbar on zoom out after hiding it when zoomed in
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox23 verified, firefox24 verified, fennec23+)
VERIFIED
FIXED
Firefox 24
People
(Reporter: jchen, Assigned: cwiiis)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
kats
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
STR
1) Go to google.com
2) Zoom in
3) Scroll down to hide the dynamic toolbar
4) Zoom out
ER
Scroll down to reshow the dynamic toolbar
AR
Cannot scroll/reshow the toolbar without zooming in again
Comment 1•11 years ago
|
||
Dupe of bug 865872?
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #1)
> Dupe of bug 865872?
From the comments, that one seems to be WFM in the latest Nightlies?
This bug I can reproduce in the latest Nightly.
Comment 3•11 years ago
|
||
Similar to bug 866772
Updated•11 years ago
|
Updated•11 years ago
|
Blocks: dynamic-toolbar
Updated•11 years ago
|
Priority: -- → P1
Updated•11 years ago
|
Assignee: nobody → chrislord.net
Updated•11 years ago
|
tracking-fennec: ? → 23+
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #753788 -
Flags: review?(bugmail.mozilla)
Updated•11 years ago
|
Attachment #753788 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Sorry, the last one wasn't quite enough - that works when the page shrinks itself while you aren't scrolling, but doesn't work while you are because animations are cancelled on every scrollBy call.
This makes sure the toolbar also gets shown when pan/zoom has stopped.
Attachment #753788 -
Attachment is obsolete: true
Attachment #753841 -
Flags: review?(bugmail.mozilla)
Updated•11 years ago
|
Attachment #753841 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e715c8a5c38
Status: NEW → ASSIGNED
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•11 years ago
|
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Comment 8•11 years ago
|
||
I am still able to reproduce the issue on Firefox Mobile 23 beta 1 on the Acer Iconia Tab A500 (Android 3.0) and the Samsung Galaxy Tab (Android 4.0) using the scenario from Comment 0, the scenario from bug 873016 or by opening about: and just scrolling to hide the URL bar. Shouldn't this be uplifted since 23 is now on Beta?
Updated•11 years ago
|
Flags: needinfo?(chrislord.net)
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 753841 [details] [diff] [review]
Show dynamic toolbar when page shrinks v2
Argh, I didn't realise this didn't land on 23 :/
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: If a page resizes itself smaller than the screen while the toolbar is hidden, the toolbar cannot be shown
Testing completed (on m-c, etc.): Been on m-c and aurora for a while, no complaint
Risk to taking this patch (and alternatives if risky): Risk of showing the toolbar when it's inappropriate to do so, but given how long this has been on m-c, I think it's low.
String or IDL/UUID changes made by this patch: None
Attachment #753841 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(chrislord.net)
Updated•11 years ago
|
Attachment #753841 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•11 years ago
|
||
Comment 11•11 years ago
|
||
Verified fixed on:
Build: Firefox for Android 23.0b8(2013-07-23)
Device: Samsung Galaxy Tab
Android: 4.0.4
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•