Closed
Bug 869469
Opened 12 years ago
Closed 12 years ago
GC: Fix typo in rooting analysis script and add annotation for MDefinition.opName
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Here's a patch to fix a typo in run_complete, and also to fix the ananlysis thinking MDefinition.opName can GC - it's virtual, but all implementations return a constant string.
Attachment #746421 -
Flags: review?(sphink)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 746421 [details] [diff] [review]
Proposed changes
Review of attachment 746421 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry, I fixed that typo locally and forgot I hadn't pushed it. It was a last-minute change to my last commit.
Attachment #746421 -
Flags: review?(sphink) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•