Closed Bug 869717 Opened 12 years ago Closed 12 years ago

CSS Tweaks needed for MMS placeholders

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- fixed

People

(Reporter: gnarf, Assigned: steveck)

References

Details

Attachments

(1 file)

We need to add background-size: 100%; to the placeholders, and set width: auto on images. Also, we need to right align the images on the right sides
Depends on: 840055
blocking-b2g: --- → leo+
Whiteboard: [NO_UPLIFT]
Can you please provide additional context around issue? Perhaps screenshots showing the issue and build info if unique. Thanks!
Flags: needinfo?(gnarf37)
Sorry, there are two placeholders for incoming video and audio messages, these are just some css tweaks discussed with borja that were needed to these elements - It's a fairly tiny fix. Basically when the high DPI devices are used, (or the responsive.css) the sizes of the background images are wrong, also image messages don't get the right width/height at the moment
Flags: needinfo?(gnarf37)
It seems the background image placeholders already set background-size: 100% and width: auto now. I'll submit another patch for right align the images in outgoing message.
Assignee: nobody → schung
Attachment #750891 - Flags: review?(felash)
Comment on attachment 750891 [details] Right align the media content in outgoing message r=me with the nit addressed please fix the nit and then you can land without a review :)
Attachment #750891 - Flags: review?(felash) → review+
Land in master: df3d2e10132cf05b9cdcf7032a0657c5f109e948
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [NO_UPLIFT]
v1-train:e259573
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: