Closed
Bug 86979
Opened 24 years ago
Closed 23 years ago
"launch file" after downloading does not honor OS file associations
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: jruderman, Assigned: bugzilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
When I download a zipped nightly, Mozilla helpfully includes a "launch file" option in the download dialog after the download is complete. However, clicking "launch file" opens WinZip, even though I have .zip files associated with FreeZip. This results in WinZip telling me that WinZip is not associated with zip files. (Fwiw, IE has a similar feature that screws up in a different way: it launches FreeZip, but in the wrong directory, so the contents of the zip file end up in the wrong place.) Windows NT 4.0, Mozilla 2001 061804.
Comment 1•24 years ago
|
||
see also bug 87218, which is kinda like the opposite of this one: user-define setting in Netscape6.x are clobbered by OS setting.
Comment 3•24 years ago
|
||
Launch file relies on the windows shell to figure out what application is bound to .zip files. Free zip apparently did not poke your registery settings to be the windows handler for .zip files.
Reporter | ||
Comment 4•24 years ago
|
||
If I double-click on a .zip file in the explorer shell, FreeZip opens and immediately unzips the file into the same directory. mscott, are you saying that there are multiple registry settings needed to fully associate file types, and FreeZip is missing one of them?
Comment 5•24 years ago
|
||
wow, that's fascinating. A double click in explorere launches free zip but the launch button in mozilla launches winzip? Hmm, I'm at a loss to explain that because the launch button just tells the explorere shell to simulate a double click of the file: nsLocalFile::Launch is defined as: // use the app registry name to launch a shell execute.... LONG r = (LONG) ::ShellExecute( NULL, "open", (const char *) path, NULL, NULL, SW_SHOWNORMAL);
Build 2001061804 It would seem that Mozilla is not using the "default" action to open the zip file. It looks for an action called "open", which Freezip doesn't do. Freezip's default action is called "unzip". Winzip's default action is "open" and somehow (don't ask me how) zip files are still associated to winzip (if you check in Window's 'Folder Options'->'File Types' you will find that Winzip's default extension is .zip and freezip's default extension is also .zip). I wasn't able reproduce this bug as (in the build I'm using) "Launch File" is disabled. Will test again when I get a new build
Confirmed in Build 2001062204 Mozilla is actually using 'open' rather than the default 'unzip'. so the "open" in nsLocalFile::Launch needs to be some value gotten from the registry that's the default? for freezip it would be in HKEY_CLASSES_ROOT\freezip\Shell\(Default)
Reporter | ||
Comment 8•24 years ago
|
||
We currently pass "open" as the second parameter to ShellExectue. According to http://msdn.microsoft.com/library/psdk/shellcc/shell/Functions/ShellExecute.htm, we should be passing in NULL, which does the following: * For systems prior to Microsoft Windows 2000, the default verb is used if it is valid and available in the registry. If not, the "open" verb is used. * For Windows 2000 and later systems, the default verb is used if available. If not, the "open" verb is used. If neither verb is available, the system uses the first verb listed in the registry.
Mozilla Build id: 2001 060703 There are occassions when the Launch File button does not get enabled after the download has completed. The button's enabling is flaky at best, I just downloaded a file and the Launch button didn't get enabled... http://www.rpi.edu/~mehtamr/Resume.rtf
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.3
Assignee | ||
Comment 11•24 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 13•23 years ago
|
||
I don't think this was ever fixed. It's still broken for me, and I still see "open" in the code.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 14•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Status: REOPENED → ASSIGNED
Target Milestone: mozilla0.9.3 → mozilla0.9.7
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Assignee | ||
Comment 16•23 years ago
|
||
tested, worksforme, got r=ben sr=hewitt, checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•23 years ago
|
||
I can't verify this fix because the "launch file" button is now disabled for zip files :(
Comment 18•22 years ago
|
||
tested using 2002.07.23.08-1.0 comm branch bits on win2k. true, in the progress dlg the "launch file" button is disabled...however, in the download manager window, i can select the entry for the .zip file i downloaded, and the "launch file" button there is enabled and does work. i'll give this an rs vrfy. if there's a seperate issue with "launch file" being disabled in the progress dlg, it might be better to track it seperately...
Status: RESOLVED → VERIFIED
Keywords: verifyme
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•