Closed
Bug 86992
Opened 23 years ago
Closed 23 years ago
Copies and Folders panel is too big
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: bugzilla, Assigned: racham)
References
()
Details
(Whiteboard: Have Fix)
Attachments
(11 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
image/jpeg
|
Details | |
(deleted),
image/jpeg
|
Details | |
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
image/jpeg
|
Details | |
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
image/jpeg
|
Details | |
(deleted),
image/jpeg
|
Details |
Screenshot says it all.
Reporter | ||
Comment 1•23 years ago
|
||
URL is http://kerz/mail.gif.
I notice in the other bug that the panel fit in your screenshots. Please create
a new profile so the window is the size it will be for everyone else when
testing your stuff. I can only hope that you didn't see this problem to check
something like this in.
URL: http://kerz/mail.gif
Comment 2•23 years ago
|
||
"I can only hope that you didn't see this problem to check
something like this in."
Bhuvan, are you purposely doing this to appear human? ;-)
Looks like a spacing issue, can you get this in 9.2?
Looks like it's problem only for every first time user views that panel.
Clicking on some other settings (like Server settings) and coming back to Copies
and Folders seem to have magically fixed it.
BTW, I haven't noticed this problem in the Classic skin mode.
I will talk to Joe about this weirdness.
Anyway, I am cutting on all separators so that we can provide better
accommodation always.
Adding Joe Hewitt to the cc list.
Looks like the grid layout I used to arrange the UI seemed to getting drawm much
before the images and items are loaded. So, the UI looks all cut off first time.
According to this hypothesis, the reason it works fine the second time (when
you click back on this setting && ofcourse resize will fix it in a different
way by providing more area for the layout)is that all elements are available and
are drawn properly.
Hewitt suggested that I can try simulating the grid layout using boxes and see
if we can get around this problem. I will give a shot at that.
Adding Eric Vaughan to the cc list for if he has any ideas on other easier
alternatives here.
After changing the layout to use boxes and removing the seperators to improve
the UI, CopiesAndFolders panel look like the images posted in attachments
(39884, 39885).
Modern skin is still slightly off in terms of height. But we do see all the
elements that need to be there in the panel. There is a need to rework all our
panels to reduce the accountmanager window size and adjust the prefs in the
panels accordingly. Unless there is a better short term solution, I would like
to proceed with this patch for now.
Any input is welcome.
Seth & Hewitt, please review. thanks.
bhuvan
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•23 years ago
|
||
Note : Screenshots are taken on a brand new profile's mail account.
Assignee | ||
Comment 11•23 years ago
|
||
Scott,
Can we consider this for nsBranch ? It is certainly better than the status quo.
Keywords: patch
Whiteboard: Have Fix
Comment 12•23 years ago
|
||
you wrote: "Looks like the grid layout I used to arrange the UI seemed to
getting drawn much before the images and items are loaded."
are you just working around a grid bug? are there other areas in the app where
grid has this problem?
Reporter | ||
Comment 13•23 years ago
|
||
Can we get this checked in?
Comment 14•23 years ago
|
||
setting to 0.9.4
it's not something that would hold up 0.9.3
it still seems like we're working around a grid bug.
but blake, if you want to review the two patches, I'll sr.
when racham gets back from vacation, he can drive this in.
Target Milestone: --- → mozilla0.9.4
Comment 15•23 years ago
|
||
Bhuvan can you drive getting this patch checked in soon? If you can't get to it
soon then we need to push this off to .9.5 per the triage meeting today. So feel
free to change this to .9.5 if you can't get the patch in.
Assignee | ||
Comment 16•23 years ago
|
||
Filed bug 95442 to take care of the grid layout problem.
However, I tried to reproduce this bug on my laptop (with latest trunk build
downloaded from sweetlou [2001081504], with a brand new profile). I noticed that
the situation wrt to menulists is improved. They are getting drawn properly. May
be the grid bug is fixed or my settings are changed. Blake, can you confirm if
you still see the problem where menulists are getting cut on the righthand side.
nbaca, karen, can you also check if you can reproduce this bug as posted at
http://kerz/mail.gif ? My update build is going on. I will check again once that
is done.
If the grid layout problem is fixed, that leaves us with the part of fixing the
height of the panel. I can get rid of the separators whereever possible so that
we can get all the components into the view.
Reporter | ||
Comment 17•23 years ago
|
||
Yeah, now it's just a height problem.
Comment 18•23 years ago
|
||
Build 2001-08-15-04: WinMe, I see the same problem with the height issue.
Assignee | ||
Comment 19•23 years ago
|
||
Assignee | ||
Comment 20•23 years ago
|
||
Assignee | ||
Comment 21•23 years ago
|
||
Assignee | ||
Comment 22•23 years ago
|
||
Assignee | ||
Comment 23•23 years ago
|
||
After removing the separators to improve on the height issue, things looked fine
with clasic skin. Modern skin still doesn't show the panel as expected (not even
as it was like in attachment #39884 [details]). I noticed that the icons have
changed/improved since that attachment (#39884) was posted. But it looks like
that demanded more space around the widgets.
Joe, is there any way to tweak this further via css rules..?
Assignee | ||
Comment 24•23 years ago
|
||
We already have class named 'small-margin' to help us in these kind of
situations (with minimal margin values). Thanks Joe.
New patch, which works with both classic and modern skins, coming up...
Will also post updated screen shots.
Assignee | ||
Comment 25•23 years ago
|
||
Assignee | ||
Comment 26•23 years ago
|
||
Assignee | ||
Comment 27•23 years ago
|
||
Assignee | ||
Comment 28•23 years ago
|
||
Joe,
Please review the latest patch (#46535).
thanks.
Comment 29•23 years ago
|
||
r or sr=sspitzer, which ever you need.
Assignee | ||
Comment 31•23 years ago
|
||
FYI :
I did correct
<groupbox orient="vertical" class="small=margin">
to
<groupbox orient="vertical" class="small-margin">
in my patch.
Comment 32•23 years ago
|
||
r=ssu for the last patch (id=46535) with the fix of "small=margin" to
"small-margin".
a=roc+moz on behalf of drivers
Assignee | ||
Comment 34•23 years ago
|
||
Fix checked in.
Assignee | ||
Comment 35•23 years ago
|
||
Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 36•23 years ago
|
||
Veriifed on all the platforms WinNT, Mac OSX & Linux for 10-15-05-0.9.4 builds.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•