Closed
Bug 870103
Opened 12 years ago
Closed 11 years ago
BackgroundPageThumbs should disable plugins and HTML5 media in its browser
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
(deleted),
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
BackgroundPageThumbs should disable HTML5 media in its browser. Bug 759946 is necessary but not sufficient, since BackgroundPageThumbs's browser is remote. There will need to be some way to send "allow media?" to remote docshells. (It may be helpful to see bug 841495 attachment 744963 [details] [diff] [review] for how ContentParent and TabChild were modified to support remote private browsing.)
Assignee | ||
Comment 1•12 years ago
|
||
Oops, bug 759964 I meant, not 759946.
Assignee | ||
Comment 2•12 years ago
|
||
Actually that might not be true. The content script, backgroundPageThumbsContent.js, could probably just set allowMedia on the docshell. The reason PB mode had to be forwarded to the remote process was that it had to be set up right after the docshell was created. I don't know if that's true for allowMedia, too.
Assignee | ||
Comment 3•12 years ago
|
||
Oh, this bug should set allowPlugins = false, too, unless that turns out to be unexpectedly hairy, warranting its own bug.
Summary: BackgroundPageThumbs should disable HTML5 media in its browser → BackgroundPageThumbs should disable plugins and HTML5 media in its browser
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → adw
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•11 years ago
|
||
This is all that's needed.
Attachment #766158 -
Flags: review?(mhammond)
Updated•11 years ago
|
Attachment #766158 -
Flags: review?(mhammond) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•