Closed Bug 870124 Opened 11 years ago Closed 11 years ago

[MMS][User Interface] SMS counter display

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 verified)

Status:
RESOLVED FIXED
Milestone:
1.1 CS (11may)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- verified

People

(Reporter: danheberden, Assigned: greg)

References

Details

(Keywords: feature)

Attachments

(4 files)

Counter styles broken
(deleted), image/png
Details
Pull Request
(deleted), text/x-github-pull-request
borjasalguero
: review+
Details
Counter with new patch. Needs UX input.
(deleted), image/png
Details
indications on how must the counter be aligned
(deleted), image/png
Details 
The SMS counter/message-count display is no longer styled properly with the MMS compatible composition area and new layout.
Blocks: mms-userstories
Priority: -- → P1
Whiteboard: dev-branch
Target Milestone: --- → 1.1 CS (11may)
Whiteboard: dev-branch → dev-branch [NO_UPLIFT]
Depends on: 840069
Assignee: nobody → greg
Attached image Counter styles broken (deleted) — 
blocking-b2g: --- → leo+

    
    

    
  

      
      
      
      

        Attached file
          
        Pull Request (deleted)
        — 
      

    


  

        Attachment #747592 -
        Flags: review?(arnau)

        Attachment #747592 -
        Flags: review?(fbsc)

    
    

    
  
Just waiting for review from :rnowm per :borjasalguero

    
    

    
  
Here we have to ways:
- Wait to :rnowm due to we are changing the layout, and we could keep the previous one.
- Keep the layout as it is and I will review your code asap.
Keywords: feature

    
  
Blocks: 870120

        Attachment #747592 -
        Flags: review?(arnau)

        Attachment #747592 -
        Flags: review?(fbsc) → review+

    
  
Blocks: 840035

    
    

    
  
If I'm not mistaken, this landed on bocoup's dev branch. Please add a whiteboard comment, and put the commit url here. Thanks

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/9ef20d89bd64e6ba3516b0675e357da0cc3cc4e8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
  
Whiteboard: dev-branch [NO_UPLIFT] → [NO_UPLIFT]

    
  
Whiteboard: [NO_UPLIFT]

    
    

    
  
v1-train:5896863

          status-b2g18:
          --- → fixed

    
    

    
  
Issue no longer repros on Leo device
Build ID: 20130809041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/45480132106b
Gaia: c9d0901564cf6f50e375ab48e4124b8378a2e246
Platform Version: 18.1
SMS counter displaying as expected.

          status-b2g18:
          fixed → verified
Attachment mime type: text/plain → text/x-github-pull-request

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: