In bug 859220, we plan to split IccManager and MobileConnection. The IccManager will no longer inside MobileConnection but in navigator. Gaia side needs to make corresponding changes for import contacts from SIM.

Bug 859220 is already r+ and sr+. I can help to provide the Gaia patch for this bug .

Gaia pull request #9640

Comment on attachment 747356 [details] gaia pull request #9640 Hi Jose, Could you review this patch for me? Thanks.

(In reply to Edgar Chen [:edgar][:echen] from comment #3) > Comment on attachment 747356 [details] > gaia pull request #9640 > > Hi Jose, > > Could you review this patch for me? > > Thanks. I add a checking for IccManager in this patch. In this way we can make sure it won't break 'import SIM contacts' function no matter bug 859220 is landed or not. Otherwise, 'import SIM contacts' function may fail until both bugs are landed. (bug 870237 and bug 859220)

:jmcf, ping?

Comment on attachment 751603 [details] Alternative patch This patch looks good to me. I am not sure should this patch need to be merged into v1 or not. Because the gecko's changes is only happened in m-c. If we only need to merge this in master branch, maybe we don't need to check Contact API. Anyway, I will let you to decide this. Thanks, Jose. :)

Comment on attachment 751603 [details] Alternative patch r+ Just left some comments on github, about being a bit more conservative and check for the platform features, so we could use this PR and fix the problem that we have on nightly and b2g for desktop that we cannot go to settings cause icc is undefined. Great job JMC! Cheers.