Closed Bug 870371 Opened 12 years ago Closed 12 years ago

Add Javascript interface to Android OrderedBroadcast

Categories

(Firefox Health Report Graveyard :: Client: Android, defect, P1)

All
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(2 files)

We are designing Firefox Health Report on Android to mostly be implemented in Java, and with this design we need a way to trigger shuttling a report from Java to Javascript. One way to do this is for JS to trigger Java (Fennec) to send an Android Ordered Broadcast, which a background service can then respond to. Decoupling in this way makes it possible to swap in testing code from the Android Sync git repository.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Summary: Add Javascript interface to Android Ordered Broadcast → Add Javascript interface to Android OrderedBroadcast
I'm happy with this, modulo your weird outdated JavaScript conventions ;) See GitHub comments. Fold and put a patch here, and I'll rubberstamp.
Comment on attachment 748285 [details] [diff] [review] Bug 870371 - Add Javascript interface to Android OrderedBroadcast. r=rnewman Review of attachment 748285 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/modules/Makefile.in @@ +12,4 @@ > EXTRA_JS_MODULES = \ > LightweightThemeConsumer.jsm \ > JNI.jsm \ > + OrderedBroadcast.jsm \ Use the right flavor of whitespace.
Attachment #748285 - Flags: review?(rnewman) → review+
Attachment #748286 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → Firefox 23
Depends on: 873029
Comment on attachment 748286 [details] [diff] [review] Bug 870371 - Android OrderedBroadcast tests. r=rnewman Review of attachment 748286 [details] [diff] [review]: ----------------------------------------------------------------- BTW, I am happy to provide feedback on your robocop patches. ::: mobile/android/base/tests/testOrderedBroadcast.java.in @@ +57,5 @@ > + > + mAsserter.dumpLog("Unregistering org.mozilla.gecko.test.receiver broadcast receiver"); > + > + if (mReceiver != null) { > + getActivity().getApplicationContext().unregisterReceiver(mReceiver); Is it okay to call this after BaseTest.tearDown() has called finishOpenedActivities()?
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: